Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preset json format + Add device info #9465

Merged
merged 19 commits into from
Jul 22, 2021
Merged

Update preset json format + Add device info #9465

merged 19 commits into from
Jul 22, 2021

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jul 22, 2021 •
edited
Loading

  • Change preset json format to SCHEMA_VERSION = 1
  • Reading backward compatible - old style (flat) preset json files is supported

Tracked on [LRS-210]

@Nir-Az Nir-Az requested review from maloel and ev-mp July 22, 2021 07:19
@Nir-Az Nir-Az force-pushed the add_camera_source_to_json branch from d1b63d6 to bf3eb5f Compare July 22, 2021 07:36
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/ds5/advanced_mode/json_loader.hpp Outdated
}

auto str = j.dump(4);
auto str = preset_writer.get_root().dump(4);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have something like a to_string() call for the writer?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Jul 22, 2021
View reviewed changes
src/serialized-utilities.h Outdated Show resolved Hide resolved
@maloel maloel merged commit e69cd66 into IntelRealSense:development Jul 22, 2021
@Nir-Az Nir-Az deleted the add_camera_source_to_json branch July 27, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

@ev-mp ev-mp Awaiting requested review from ev-mp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nir-Az @maloel