Integrate newer cardano-ledger and ouroboros-consensus #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carbolymer
reviewed
Mar 27, 2024
cardano-api/internal/Cardano/Api/LedgerEvents/Rule/TICK/NEWEPOCH.hs
Outdated
Show resolved
Hide resolved
24 tasks
disassembler
force-pushed
the
dnadales/api-8.10
branch
3 times, most recently
from
46af24b to
f41c70a
Compare
carbolymer
reviewed
Apr 4, 2024
dnadales
commented
Apr 4, 2024
cardano-api/cardano-api.cabal
Outdated
| @@ -1,7 +1,7 @@ | |||
| cabal-version: 3.4 | |||
|
|
|||
| name: cardano-api | |||
| version: 8.43.0.0 | |||
| version: 8.44.0.0 | |||
There was a problem hiding this comment.
This should go in a separate PR
3 tasks
dnadales
commented
Apr 4, 2024
dnadales
force-pushed
the
dnadales/api-8.10
branch
from
a1e5545 to
a1e9b03
Compare
dnadales
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
CarlosLopezDeLara and
disassembler
as code owners
Jimbo4350
reviewed
Apr 4, 2024
cardano-api/cardano-api.cabal
Outdated
| @@ -194,22 +194,23 @@ library internal | |||
| , optparse-applicative-fork | |||
| , ouroboros-consensus ^>= 0.16 | |||
| , ouroboros-consensus-cardano ^>= 0.14 | |||
| , ouroboros-consensus-diffusion ^>= 0.12 | |||
| -- TODO: ouroboros-consensus-diffusion needs to be bumped | |||
There was a problem hiding this comment.
Is this comment still relevant?
cardano-api/internal/Cardano/Api/LedgerEvents/Rule/TICK/NEWEPOCH.hs
Outdated
Show resolved
Hide resolved
| @@ -1165,6 +1165,8 @@ mkProtocolInfoCardano (GenesisCardano dnc byronGenesis shelleyGenesisHash transC | |||
| } | |||
| , Consensus.hardForkTriggers = ncHardForkTriggers dnc | |||
| , Consensus.ledgerTransitionConfig = transCfg | |||
| -- FIXME: add a comment mentioning when the a RE should change 'checkpoints' (eg around Genesis release). | |||
There was a problem hiding this comment.
Is this comment still relevant?
Jimbo4350
approved these changes
Apr 4, 2024
disassembler
force-pushed
the
dnadales/api-8.10
branch
from
c59bcb2 to
0ebcd93
Compare
3 tasks
carbolymer
added a commit
that referenced
this pull request
Apr 4, 2024
carbolymer
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Force merged because GHA was not responding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist