-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cardano-api-8.44
, New required flag --reference-script-size
for transaction calculate-min-fee
#680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
disassembler
force-pushed
the
dnadales/cli-8.10
branch
6 times, most recently
from
April 4, 2024 05:04
c9213ae
to
5132a2b
Compare
dnadales
force-pushed
the
dnadales/cli-8.10
branch
from
April 4, 2024 16:44
b469aeb
to
87c9b16
Compare
This patch also adds the reference script size to the arguments needed to calculate the transaction minimum fee.
dnadales
force-pushed
the
dnadales/cli-8.10
branch
from
April 4, 2024 16:46
87c9b16
to
10c1b9e
Compare
dnadales
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
April 4, 2024 16:46
3 tasks
carbolymer
reviewed
Apr 4, 2024
, ouroboros-consensus-cardano >= 0.14.2 | ||
, ouroboros-consensus-protocol >= 0.7 | ||
, ouroboros-consensus >= 0.17 | ||
-- TODO: bump consensus back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment needed?
carbolymer
approved these changes
Apr 4, 2024
Jimbo4350
requested changes
Apr 4, 2024
Jimbo4350
approved these changes
Apr 4, 2024
carbolymer
changed the title
CLI release for Node 8.10
Update cardano-api-8.44, New required flag Apr 4, 2024
--reference-script-size
for transaction calculate-min-fee
carbolymer
changed the title
Update cardano-api-8.44, New required flag
Update Apr 4, 2024
--reference-script-size
for transaction calculate-min-fee
cardano-api-8.44
, New required flag --reference-script-size
for transaction calculate-min-fee
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Requires
Checklist