-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#667 Add ref-script-size query command #672
Conversation
3292df5
to
f582c37
Compare
] | ||
[--out-file FILE] | ||
|
||
Calculate the reference input scripts size in bytes for provided transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be transaction input. However we should also allow specification of txid(s) if the user has access to the reference script creation transaction
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the text. I'll add that in the follow-up PR, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, great job ❤️
f582c37
to
4712d7d
Compare
4712d7d
to
5146e2d
Compare
5146e2d
to
75779b0
Compare
75779b0
to
cf89bcb
Compare
Changelog
Context
Requires:
This PR is rebased onto #680 - only
#667 Add ref-script-size query command
commit contains the changes related to this feature.Checklist