Disallow withdrawals to non-delegated keyhashes post-bootstrap #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
commented
Aug 21, 2024
teodanciu
force-pushed
the
td/withdrawals-to-nondelegated-accounts
branch
2 times, most recently
from
747e230 to
0a137b2
Compare
lehins
changed the title
teodanciu
force-pushed
the
td/withdrawals-to-nondelegated-accounts
branch
from
0a137b2 to
9030d83
Compare
teodanciu
force-pushed
the
td/withdrawals-to-nondelegated-accounts
branch
2 times, most recently
from
904f448 to
fd0f7e1
Compare
teodanciu
force-pushed
the
td/withdrawals-to-nondelegated-accounts
branch
2 times, most recently
from
1717908 to
6022dbf
Compare
teodanciu
force-pushed
the
td/withdrawals-to-nondelegated-accounts
branch
from
6022dbf to
5f132d4
Compare
lehins
reviewed
Sep 9, 2024
| @@ -134,7 +136,7 @@ data ConwayLedgerPredFailure era | |||
| = ConwayUtxowFailure (PredicateFailure (EraRule "UTXOW" era)) | |||
| | ConwayCertsFailure (PredicateFailure (EraRule "CERTS" era)) | |||
| | ConwayGovFailure (PredicateFailure (EraRule "GOV" era)) | |||
| | ConwayWdrlNotDelegatedToDRep (Set (Credential 'Staking (EraCrypto era))) | |||
| | ConwayWdrlNotDelegatedToDRep (NonEmpty (Credential 'Staking (EraCrypto era))) | |||
There was a problem hiding this comment.
@teodanciu You didn't apply my suggestion of changing this to
-ConwayWdrlNotDelegatedToDRep (NonEmpty (Credential 'Staking (EraCrypto era)))
+ConwayWdrlNotDelegatedToDRep (NonEmpty (KeyHash 'Staking (EraCrypto era)))Do you mind submitting a PR with this fix?
There was a problem hiding this comment.
Original suggestion: #4555 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4092
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)