Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELEG Imp spec #4597

Merged
merged 1 commit into from
Sep 11, 2024
Merged

DELEG Imp spec #4597

merged 1 commit into from
Sep 11, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Sep 4, 2024

Description

Imp tests for DELEG rule, testing various scenarios of delegating stake, votes and both.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Let's wait for #4555 be merged, since this PR depends on it.

@teodanciu teodanciu force-pushed the td/deleg-imp-spec branch 3 times, most recently from 733fe99 to 5da50c6 Compare September 10, 2024 14:51
@teodanciu teodanciu requested a review from lehins September 10, 2024 14:51
@teodanciu
Copy link
Contributor Author

This is now adjusted to the fix for the unexpected deposit failure when unregistering a non-registered credential, that has been merged to master.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@teodanciu teodanciu enabled auto-merge September 11, 2024 12:02
@teodanciu teodanciu merged commit c456f5e into master Sep 11, 2024
147 of 148 checks passed
@teodanciu teodanciu deleted the td/deleg-imp-spec branch September 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants