Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.9.1 cardano-cardano nodes have zero peers to share. #4839

Closed
karknu opened this issue Apr 2, 2024 · 0 comments · Fixed by #4841
Closed

8.9.1 cardano-cardano nodes have zero peers to share. #4839

karknu opened this issue Apr 2, 2024 · 0 comments · Fixed by #4841
Assignees
@coot
Labels
bug Something isn't working peer-sharing Issues / PRs related to peer sharing

Comments

@karknu
Copy link
Contributor

karknu commented Apr 2, 2024

The refactoring in #4795 completely broke peersharing.
Consensus creates one StrictTVar m (PublicPeerSelectionState peeraddr) and P2P creates another. The governor updates the one created by P2P. The end result is that the PeerShare server will have no peers to share because it uses the state variable created by consensus.
@karknu karknu added bug Something isn't working peer-sharing Issues / PRs related to peer sharing labels Apr 2, 2024
@coot coot self-assigned this Apr 3, 2024
@amesgen amesgen mentioned this issue Apr 4, 2024
Closed
@coot coot mentioned this issue Apr 4, 2024
Merged
9 tasks
@coot coot linked a pull request Apr 4, 2024 that will close this issue
PeerSharingAPI fix, master branch #4841
Merged
9 tasks
@coot coot closed this as completed in #4841 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coot coot

Labels
bug Something isn't working peer-sharing Issues / PRs related to peer sharing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PeerSharingAPI fix, master branch IntersectMBO/ouroboros-network
2 participants
@coot @karknu