Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerSharingServer refactorisation #4782 #4795

Merged
merged 4 commits into from
Mar 6, 2024
Merged

PeerSharingServer refactorisation #4782 #4795

merged 4 commits into from
Mar 6, 2024

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Feb 1, 2024

Refactor Peer Sharing

Refactors PeerSharing peerSharingServer to provide a better interface to consensus to fill via PeerSharingAPI

@bolt12 bolt12 added the peer-sharing Issues / PRs related to peer sharing label Feb 1, 2024
@bolt12 bolt12 requested a review from coot as a code owner February 1, 2024 17:32
@bolt12 bolt12 changed the title Address #4782 PeerSharingServer refactorisation #4782 Feb 1, 2024
bolt12 added a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Feb 5, 2024
@bolt12
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
4a36314
coot
coot reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a few comments.

ouroboros-network/src/Ouroboros/Network/PeerSharing.hs Outdated Show resolved Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSharing.hs Show resolved Hide resolved
ouroboros-network/sim-tests-lib/Test/Ouroboros/Network/PeerSelection/MockEnvironment.hs Outdated Show resolved Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSharing.hs Show resolved Hide resolved
@bolt12 bolt12 self-assigned this Feb 8, 2024
@bolt12 bolt12 mentioned this pull request Feb 8, 2024
Open
@bolt12 bolt12 requested review from coot and karknu February 8, 2024 16:04
@bolt12 bolt12 requested a review from coot February 12, 2024 14:41
coot
coot approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crocodile-dentist crocodile-dentist mentioned this pull request Feb 21, 2024
Merged
9 tasks
@bolt12 bolt12 requested a review from coot March 6, 2024 14:40
@bolt12 bolt12 requested a review from a team as a code owner March 6, 2024 15:10
@coot coot linked an issue Mar 6, 2024 that may be closed by this pull request
PeerSharingServer refactorisation #4782
Closed
@bolt12 @coot
Update ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs
3e42b45 
Co-authored-by: Marcin Szamotulski <coot@coot.me>
@bolt12 bolt12 enabled auto-merge March 6, 2024 20:17
@bolt12 bolt12 added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit 28aedfe Mar 6, 2024
13 checks passed
@bolt12 bolt12 deleted the bolt12/4782 branch March 6, 2024 21:11
dnadales pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 12, 2024
@bolt12 @dnadales
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
32ef788
dnadales pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 12, 2024
@bolt12 @dnadales
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
9e8805e
bolt12 added a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 14, 2024
@bolt12
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
9d38546
amesgen pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 15, 2024
@bolt12 @amesgen
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
7ca657e
amesgen pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 15, 2024
@bolt12 @amesgen
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
c39e6c7
dnadales pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 21, 2024
@bolt12 @dnadales
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
2dd409e
dnadales pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 26, 2024
@bolt12 @dnadales
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
c2f5ebf
dnadales pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 27, 2024
@bolt12 @dnadales
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
449d7cf
amesgen pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Mar 28, 2024
@bolt12 @amesgen
Integrate [ouroboros-network #4795](IntersectMBO/ouroboros-network#4795)
17cc286
@karknu karknu mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@karknu karknu Awaiting requested review from karknu

Assignees

@bolt12 bolt12

Labels
peer-sharing Issues / PRs related to peer sharing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PeerSharingServer refactorisation
4 participants
@bolt12 @coot @karknu @crocodile-dentist