Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerSharingAPI fix, master branch #4841

Merged
merged 5 commits into from
Apr 4, 2024
Merged

PeerSharingAPI fix, master branch #4841

merged 5 commits into from
Apr 4, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 4, 2024 •
edited
Loading

Description

This PR fixes the issue #4839.

  • ouroboros-network: public peer selection state
  • ouroboros-newtork: style changes
  • ouroboros-network: sim-tests-lib on Windows
  • ouroboros-network: PeerSharing unit test

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot added the peer-sharing Issues / PRs related to peer sharing label Apr 4, 2024
@coot coot self-assigned this Apr 4, 2024
@coot coot requested a review from a team as a code owner April 4, 2024 15:14
coot added 4 commits April 4, 2024 17:32
@coot
ouroboros-network: public peer selection state
5b259e4 
Public peer selection state should be passed through
`Diffusion.Arguments` rather than created inside diffusion because we
need it to create some of the applications (e.g. peer sharing), which
are instantiated in `ouroboros-consensus`.
@coot
ouroboros-newtork: style changes
f2b1395
@coot
ouroboros-network: sim-tests-lib on Windows
2e4646e 
We don't need to limit the simulation tests on Windows, since we don't
run them on Windows in CI.
@coot
ouroboros-network: PeerSharing unit test
30c7a2c
@coot coot force-pushed the coot/peerSharingAPI-fix branch from 9e3f225 to 8d82650 Compare April 4, 2024 15:33
@coot coot requested a review from karknu April 4, 2024 15:34
@coot coot linked an issue Apr 4, 2024 that may be closed by this pull request
8.9.1 cardano-cardano nodes have zero peers to share. #4839
Closed
@coot coot mentioned this pull request Apr 4, 2024
Merged
9 tasks
karknu
karknu approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just two minor comments

ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/Types.hs Show resolved Hide resolved
ouroboros-network/sim-tests-lib/Test/Ouroboros/Network/Testnet.hs Show resolved Hide resolved
@coot coot force-pushed the coot/peerSharingAPI-fix branch from 8d82650 to d0e720b Compare April 4, 2024 17:04
@coot coot enabled auto-merge April 4, 2024 17:07
@coot coot added this pull request to the merge queue Apr 4, 2024
Merged via the queue into master with commit 9c75bd4 Apr 4, 2024
12 of 13 checks passed
@coot coot deleted the coot/peerSharingAPI-fix branch April 4, 2024 18:41
@coot coot changed the title PeerSharing fix PeerSharingAPI fix Apr 15, 2024
@coot coot changed the title PeerSharingAPI fix PeerSharingAPI fix, master branch Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

Assignees

@coot coot

Labels
peer-sharing Issues / PRs related to peer sharing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.9.1 cardano-cardano nodes have zero peers to share.
2 participants
@coot @karknu