Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 32-bit backend for ed25519 #6

Closed
ernieturner opened this issue Jan 22, 2019 · 1 comment
Closed

Use 32-bit backend for ed25519 #6

ernieturner opened this issue Jan 22, 2019 · 1 comment
Assignees
@ernieturner
Milestone
2019-07-26

Comments

@ernieturner
Copy link
Contributor

Our ed25519 dependency in recrypt supports using a 32-bit backend instead of the default 64 bit. This both improves performance and reduces the file size in the WASM code. We should figure out how to enable that feature at the WASM level to gain these improvements.
@ernieturner ernieturner added this to the 2019-01-28 milestone Jan 22, 2019
@ernieturner ernieturner self-assigned this Jan 22, 2019
@ernieturner ernieturner changed the title Use 32-bit backend for ed25519 [Blocked] Use 32-bit backend for ed25519 Jan 22, 2019
@ernieturner
Copy link
Contributor Author

I think this might be blocked on this curve-25519 issue. Attempting to compile ed25519 with the u32_backend for the wasm target causes a whole bunch of compiler failures. If we just set the u32-backend feature for recrypt-rs blindly (not specifically for the wasm target) then it compiles fine, but that's obviously not something we want to do.

We'll retry if/when this ticket ends up getting fixed.

@ernieturner ernieturner removed this from the 2019-01-28 milestone Jan 22, 2019
@ernieturner ernieturner mentioned this issue Feb 6, 2019
Closed
@ernieturner ernieturner added this to the 2019-07-26 milestone Jul 16, 2019
ernieturner pushed a commit that referenced this issue Jul 16, 2019
#6 Consume feature of recrypt to work for 32 bit backend ed25519. Upd…
6dde8f9 
…ate all dependencies and fix various fallout from it
ernieturner pushed a commit that referenced this issue Jul 16, 2019
#6 Consume feature of recrypt to work for 32 bit backend ed25519.… (#12)
67e4726 
* #6 Consume feature of recrypt to work for 32 bit backend ed25519. Update all dependencies and fix various fallout from it

* Use released version of recrypt, bump version, add changelog
@ernieturner ernieturner changed the title [Blocked] Use 32-bit backend for ed25519 Use 32-bit backend for ed25519 Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ernieturner ernieturner

Labels
None yet
Projects
None yet
Milestone
2019-07-26
Development

No branches or pull requests
2 participants
@coltfred @ernieturner