#6 Consume feature of recrypt to work for 32 bit backend ed25519. Update all dependencies and fix various fallout from it #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ernieturner
commented
Jul 16, 2019
ernieturner
commented
- Upgrade Travis to use Rust 1.36
- Consume new feature of recrypt to use ed25519 32 bit backend
- Update depdendencies
- A number of changes in the wasm-bindgen code forced us to modify our JS shims
added 3 commits
July 16, 2019 09:35
…ate all dependencies and fix various fallout from it
clintfred
approved these changes
Jul 16, 2019
| return { | ||
| privateKey: new Uint8Array(privateKey), | ||
| publicKey: new Uint8Array(publicKey), | ||
| }; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Are the following 4 functions new functionality for the binding?
There was a problem hiding this comment.
They are not. Previously this class just extended the underlying WASM-generated class (change on line 61 above) and these methods just called directly through to the auto-generated code. But because of some changes to the auto-generated code from wasm-bindgen extending the class is no longer possible. So instead I had to write passthrough wrappers for these functions.
There was a problem hiding this comment.
Makes sense. Thanks for the explanation!
coltfred
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.