Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing scripts #1672

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Removing scripts #1672

merged 1 commit into from
Nov 25, 2020

Conversation

dannylamb
Copy link
Contributor

@dannylamb dannylamb commented Oct 30, 2020

Purpose / why

Gets rid of the travis scripts that are now living at https://github.com/Islandora/islandora_ci

What changes were made?

git rm -rf .scripts

Verification

There be no .scripts folder!

Interested Parties

@rosiel This should wait until we've made subsequent PRs to EVERY REPO to use https://github.com/Islandora/islandora_ci in .travis.yml as opposed to this repo.


Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@dannylamb
Copy link
Contributor Author

@rosiel ^^ Those PRs should take care of everywhere we were using this repo for travis scripts.

@dannylamb
Copy link
Contributor Author

@rosiel All of the related PRs have been merged. This is ready to merge. 🎉

@rosiel rosiel merged commit 04f83ce into main Nov 25, 2020
@rosiel rosiel deleted the removing-scripts branch November 25, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants