-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated nested field logic #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but otherwise lgtm
@@ -351,21 +351,14 @@ class CriteriaCompletionChecker { | |||
|
|||
if (field.includes('.')) { | |||
const fields = field.split('.'); | |||
if (Array.isArray(eventData[fields[0]])) { | |||
return eventData[fields[0]]?.every((item: any) => { | |||
const firtElement = eventData?.[fields[0]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here
const firtElement = eventData?.[fields[0]]; | |
const firstElement = eventData?.[fields[0]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed typo
Verified logic for nested works properly |
JIRA Ticket(s) if any
Description
Updated logic same as Android PR comments to maintain consistency in functionality