MOB-9145: support isOneOf and isNotOneOf comparator #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This CI failed due to nested field, once this PR #445 merged, CI will be success |
Base automatically changed from
feature/MOB-9146-support-comparison-array-field-types
to
AUT_main
September 4, 2024 17:34
mprew97
reviewed
Sep 4, 2024
| @@ -362,7 +362,7 @@ class CriteriaCompletionChecker { | |||
| return this.evaluateComparison( | |||
| query.comparatorType, | |||
| valueFromObj, | |||
| query.value ? query.value : '' | |||
| query.value ? query.values : '' | |||
There was a problem hiding this comment.
why is this one slightly different than the others?
There was a problem hiding this comment.
Because in value we have single element and in values we have multiple element(s),
and when we create criteria for the isOneOf and isNotOneOf comparator we get values instead of value
| @@ -374,14 +374,14 @@ class CriteriaCompletionChecker { | |||
| return this.evaluateComparison( | |||
| query.comparatorType, | |||
| valueFromObj, | |||
| query.value ? query.value : '' | |||
| query.value ?? query.values ?? '' | |||
There was a problem hiding this comment.
what happens if an empty string is evaluated? should we even run the evaluation at all if value or values isn't present?
There was a problem hiding this comment.
So empty string is compared with the criteria value, empty string is not matched with value and gives result as false.
Yes, we run the evaluation.
mprew97
approved these changes
Sep 5, 2024
…otOneOf-comparator
mprew97
approved these changes
Sep 6, 2024
mprew97
deleted the
feature/MOB-9145-support-isOneOf-and-isNotOneOf-comparator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
Support isOneOf and isNotOneOf comparator
Test Steps
Video attached to the ticket, See a JIRA ticket for the video