Fix exception when editing URL file

Fixes #8008
JabRef · Aug 20, 2021 · efa248e · efa248e
1 parent 631f27c
commit efa248e
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/src/main/java/org/jabref/gui/linkedfile/LinkedFilesEditDialogViewModel.java b/src/main/java/org/jabref/gui/linkedfile/LinkedFilesEditDialogViewModel.java
@@ -1,5 +1,7 @@
 package org.jabref.gui.linkedfile;
 
+import java.net.MalformedURLException;
+import java.net.URL;
 import java.nio.file.Path;
 import java.util.List;
 import java.util.Optional;
@@ -125,7 +127,17 @@ public ObjectProperty<ExternalFileType> selectedExternalFileTypeProperty() {
     }
 
     public LinkedFile getNewLinkedFile() {
-        return new LinkedFile(description.getValue(), Path.of(link.getValue()), monadicSelectedExternalFileType.getValue().map(ExternalFileType::toString).orElse(""));
+        String fileType = monadicSelectedExternalFileType.getValue().map(ExternalFileType::toString).orElse("");
+
+        if (LinkedFile.isOnlineLink(link.getValue())) {
+            try {
+                return new LinkedFile(description.getValue(), new URL(link.getValue()), fileType);
+            } catch (MalformedURLException e) {
+                //ignore
+                return new LinkedFile(description.getValue(), link.getValue(), fileType);
+            }
+        }
+        return new LinkedFile(description.getValue(), Path.of(link.getValue()), fileType);
     }
 
     private String relativize(Path filePath) {