Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when editing an online file #8008

Closed
2 tasks done
HoussemNasri opened this issue Aug 20, 2021 · 1 comment · Fixed by #8009
Closed
2 tasks done

Exception when editing an online file #8008

HoussemNasri opened this issue Aug 20, 2021 · 1 comment · Fixed by #8009
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@HoussemNasri
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

JabRef 5.4--2021-08-19--05a0ce9 Windows 10 10.0 amd64 Java 16.0.2 JavaFX 16+8

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Select any entry with an online attached file
  2. Select the online attached file
  3. Right-click and hit Edit
  4. Hit Apply

Appendix

Exception
java.nio.file.InvalidPathException: Illegal char <:> at index 4: http://arxiv.org/pdf/2003.09501v1
  at java.base/sun.nio.fs.WindowsPathParser.normalize(Unknown Source)
  at java.base/sun.nio.fs.WindowsPathParser.parse(Unknown Source)
  at java.base/sun.nio.fs.WindowsPathParser.parse(Unknown Source)
  at java.base/sun.nio.fs.WindowsPath.parse(Unknown Source)
  at java.base/sun.nio.fs.WindowsFileSystem.getPath(Unknown Source)
  at java.base/java.nio.file.Path.of(Unknown Source)
  at org.jabref@5.4.69/org.jabref.gui.linkedfile.LinkedFilesEditDialogViewModel.getNewLinkedFile(Unknown Source)
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. external files labels Aug 20, 2021
@Siedlerchr Siedlerchr self-assigned this Aug 20, 2021
Siedlerchr added a commit that referenced this issue Aug 20, 2021
Siedlerchr added a commit that referenced this issue Aug 21, 2021
* Fix exception when editing URL file

Fixes #8008

* fix checkstyle and add changelog
@Siedlerchr
Copy link
Member

Thanks for the report! Should now be fixed in the latest dev version (currently building, ready in roughly half an hour)

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants