Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ooplugin: it shouldn't be permitted to cite a publication that doesn't yet have a bibtex key #1682

Closed
jdpipe opened this issue Aug 5, 2016 · 5 comments

Comments

@jdpipe
Copy link

jdpipe commented Aug 5, 2016

When using Jabref with LibreOffice, I can insert a reference to an entry before assign a bibtexkey to the entry. When I do so, I get "[??]" in my document. If I then click the refresh (circular arrow) icon in the ooplugin sidebar, then I get a popup message in Jabref saying "your OpenOffice/LibreOffice document references the BibTexKey 'null', which could not be found in the current database".

I think it would be more helpful if such citations were barred from being inserted in the first place, since that is the best time for the user to fix the problem. Later they can only wonder pointlessly what the [??] was referring to.

Better still, a BibTexKey could auto-generated (and again every following time, if the user desired it)

"You are citing a publication with an empty BibTexKey. A key will automatically generated [OK] [Cancel] [x] always do this in future"

Version:
JabRef 3.6dev--snapshot--2016-07-29--extractoobibdatabase--fba22d9
linux 4.4.0-31-generic amd64
Java 1.8.0_91

@oscargus
Copy link
Contributor

oscargus commented Aug 5, 2016

When working on another (code) enhancement related to the keys (#1676), I realized that in quite a few cases JabRef simply assumed that the key is set. This is clearly one of the cases causing actual issues. I'll have a look at it.

@oscargus oscargus self-assigned this Aug 5, 2016
oscargus added a commit that referenced this issue Aug 5, 2016
oscargus added a commit that referenced this issue Aug 5, 2016
oscargus added a commit that referenced this issue Aug 5, 2016
@oscargus
Copy link
Contributor

oscargus commented Aug 5, 2016

You can try a test build in five minutes at http://builds.jabref.org/fix1682 (I'm usually not this quick, but now I was looking for a small thing to fix and this fit well.)

@oscargus
Copy link
Contributor

oscargus commented Aug 5, 2016

Although the check box is a really good idea, it was a bit too much of a hassle to fix it right now.

oscargus added a commit that referenced this issue Aug 6, 2016
@jdpipe
Copy link
Author

jdpipe commented Aug 8, 2016

I tried it, worked fine. Thanks, Oscar!

oscargus added a commit to oscargus/jabref that referenced this issue Aug 8, 2016
oscargus added a commit that referenced this issue Aug 9, 2016
oscargus added a commit that referenced this issue Aug 9, 2016
Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue Aug 9, 2016
* master: (22 commits)
  Do not cite entries without a key in OpenOffice/LibreOffice (JabRef#1682) (JabRef#1683)
  Got rid of unused preferences (JabRef#1672)
  Move labelpattern (JabRef#1626)
  Implementation of shared database support (full system). (JabRef#1451)
  Removed bst from architecture tests JabRef#1699
  Update PULL_REQUEST_TEMPLATE.md
  French localization: Menu: Translation of an empty string
  French localization: Jabref_fr: empty strings translated
  Updated string similarity version (JabRef#1698)
  Minify description of release process
  Announce switch from GPL to MIT in CONTRIBUTING.md and README.md
  Some cleanups to initialize empty MetaData at fewer positions (JabRef#1696)
  Automatic group names are converted from LaTeX to Unicode (JabRef#1684)
  Update ISSUE_TEMPLATE.md (JabRef#1686)
  Removed (false) NPE issue reported by FindBugs
  More Swedish translations (JabRef#1691)
  Updated wiremock version (JabRef#1690)
  Some minor code cleanups (JabRef#1689)
  Removed dependencies of Globals.prefs in some tests (JabRef#1688)
  Lookup BibEntry from ISBN and merge information (JabRef#1621)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/gui/BasePanel.java
#	src/main/java/net/sf/jabref/importer/ImportMenuItem.java
#	src/main/resources/l10n/JabRef_da.properties
#	src/main/resources/l10n/JabRef_de.properties
#	src/main/resources/l10n/JabRef_en.properties
#	src/main/resources/l10n/JabRef_es.properties
#	src/main/resources/l10n/JabRef_fa.properties
#	src/main/resources/l10n/JabRef_fr.properties
#	src/main/resources/l10n/JabRef_in.properties
#	src/main/resources/l10n/JabRef_it.properties
#	src/main/resources/l10n/JabRef_ja.properties
#	src/main/resources/l10n/JabRef_nl.properties
#	src/main/resources/l10n/JabRef_no.properties
#	src/main/resources/l10n/JabRef_pt_BR.properties
#	src/main/resources/l10n/JabRef_ru.properties
#	src/main/resources/l10n/JabRef_sv.properties
#	src/main/resources/l10n/JabRef_tr.properties
#	src/main/resources/l10n/JabRef_vi.properties
#	src/main/resources/l10n/JabRef_zh.properties
@oscargus
Copy link
Contributor

Fixed in #1683

ayanai1 pushed a commit to ayanai1/jabref that referenced this issue Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants