Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cite entries without a key in OpenOffice/LibreOffice (#1682) #1683

Merged
merged 2 commits into from
Aug 9, 2016

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Aug 5, 2016

Check that all entries to be cited have non-empty keys, show a popup if there are empty keys, and generate keys if instructed to do so.

References #1682

  • Change in CHANGELOG.md described
  • Manually tested changed features in running JabRef

@oscargus oscargus added type: enhancement status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers openoffice/libreoffice labels Aug 5, 2016
// Ask if keys should be generated
int answer = JOptionPane.showConfirmDialog(this.frame,
Localization.lang("Cannot cite entries without BibTeX keys. Generate keys now?"),
Localization.lang("Cite"), JOptionPane.YES_NO_OPTION);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialogs asking a question and then having yes/no actions are generally not a good idea, because the "thinking overhead" for the user in the moment is too much. http://ux.stackexchange.com/questions/756/what-are-some-alternatives-to-the-phrase-are-you-sure-you-want-to-xyz-in-confi

Better add a button like "Generate keys" and a Cancel button.

@oscargus
Copy link
Contributor Author

oscargus commented Aug 5, 2016

capture14

@oscargus oscargus force-pushed the fix1682 branch 2 times, most recently from 96c60af to ded8226 Compare August 6, 2016 09:46
@stefan-kolb
Copy link
Member

Please do not use "Implemented #1682" as title. One cannot follow the link to the root issue 😄 A small description makes it much easier.

@stefan-kolb
Copy link
Member

Otherwise, please rebase and merge 👍

@oscargus oscargus changed the title Implemented #1682 Do not cite entries without a key in OpenOffice/LibreOffice (#1682) Aug 9, 2016
@oscargus oscargus merged commit db343dc into master Aug 9, 2016
@oscargus oscargus deleted the fix1682 branch August 9, 2016 15:39
Siedlerchr added a commit to Siedlerchr/jabref that referenced this pull request Aug 9, 2016
* master: (22 commits)
  Do not cite entries without a key in OpenOffice/LibreOffice (JabRef#1682) (JabRef#1683)
  Got rid of unused preferences (JabRef#1672)
  Move labelpattern (JabRef#1626)
  Implementation of shared database support (full system). (JabRef#1451)
  Removed bst from architecture tests JabRef#1699
  Update PULL_REQUEST_TEMPLATE.md
  French localization: Menu: Translation of an empty string
  French localization: Jabref_fr: empty strings translated
  Updated string similarity version (JabRef#1698)
  Minify description of release process
  Announce switch from GPL to MIT in CONTRIBUTING.md and README.md
  Some cleanups to initialize empty MetaData at fewer positions (JabRef#1696)
  Automatic group names are converted from LaTeX to Unicode (JabRef#1684)
  Update ISSUE_TEMPLATE.md (JabRef#1686)
  Removed (false) NPE issue reported by FindBugs
  More Swedish translations (JabRef#1691)
  Updated wiremock version (JabRef#1690)
  Some minor code cleanups (JabRef#1689)
  Removed dependencies of Globals.prefs in some tests (JabRef#1688)
  Lookup BibEntry from ISBN and merge information (JabRef#1621)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/gui/BasePanel.java
#	src/main/java/net/sf/jabref/importer/ImportMenuItem.java
#	src/main/resources/l10n/JabRef_da.properties
#	src/main/resources/l10n/JabRef_de.properties
#	src/main/resources/l10n/JabRef_en.properties
#	src/main/resources/l10n/JabRef_es.properties
#	src/main/resources/l10n/JabRef_fa.properties
#	src/main/resources/l10n/JabRef_fr.properties
#	src/main/resources/l10n/JabRef_in.properties
#	src/main/resources/l10n/JabRef_it.properties
#	src/main/resources/l10n/JabRef_ja.properties
#	src/main/resources/l10n/JabRef_nl.properties
#	src/main/resources/l10n/JabRef_no.properties
#	src/main/resources/l10n/JabRef_pt_BR.properties
#	src/main/resources/l10n/JabRef_ru.properties
#	src/main/resources/l10n/JabRef_sv.properties
#	src/main/resources/l10n/JabRef_tr.properties
#	src/main/resources/l10n/JabRef_vi.properties
#	src/main/resources/l10n/JabRef_zh.properties
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openoffice/libreoffice status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants