Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry editor freeze #2220

Closed
grimes2 opened this issue Nov 1, 2016 · 10 comments · Fixed by #2225
Closed

Entry editor freeze #2220

grimes2 opened this issue Nov 1, 2016 · 10 comments · Fixed by #2225
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@grimes2
Copy link
Contributor

grimes2 commented Nov 1, 2016

JabRef 3.7-dev--snapshot--2016-11-01--master--458ee79
windows 10 10.0 amd64
Java 1.8.0_111

Steps to reproduce:

  1. open entry editor
  2. change entry
  3. Freeze. 50% CPU
@koppor
Copy link
Member

koppor commented Nov 1, 2016 via email

@grimes2
Copy link
Contributor Author

grimes2 commented Nov 1, 2016

The last commit 458ee79 seems to be bad.

@lenhard
Copy link
Member

lenhard commented Nov 2, 2016

I can confirm the behavior on current master. This renders JabRef completely unusable and is a blocker for a release of 3.7.

@lenhard lenhard added the bug Confirmed bugs or reports that are very likely to be bugs label Nov 2, 2016
@lenhard lenhard added this to the v3.7 milestone Nov 2, 2016
@koppor
Copy link
Member

koppor commented Nov 2, 2016

The commit points to #2199. I contacted @bartsch-dev

@stefan-kolb
Copy link
Member

stefan-kolb commented Nov 2, 2016

I cannot exactly reproduce this. After entering something inside the entry editor it should automatically freeze the program? I can edit and change between entries with no problems. When I add a new entry afterwards I get kind of a freeze. But some things are still functional in Jabref. i just cannot enter things in the entry editor or select different entries.

@koppor
Copy link
Member

koppor commented Nov 2, 2016

When I edit an exiting entry, I have following issues:

  1. Open entry
  2. Edit "title" field: Add three letters "abc"
  3. Click textfield of "journaltitle".
  4. Field does not get focus
  5. Click textfield of "journaltitle".
  6. Field gets focus

@chriba
Copy link
Contributor

chriba commented Nov 2, 2016

I tried to fix it, can you please try it out?
I also noticed that with #2075 the entry editor has become noticeable slower.

@grimes2
Copy link
Contributor Author

grimes2 commented Nov 2, 2016

Can you provide a build? I want to test it also.

@stefan-kolb: No. Open the entry editor by double-click on an entry in main table. Go to another entry in the main table. You don't need to edit or change a field in the entry editor at all.

@koppor
Copy link
Member

koppor commented Nov 2, 2016

The PR is #2225. I (manually) mirrored the branch fixEditorFreeze at the JabRef repo. It doesn't build as we have issues with the Medline test on the master branch. The latter refs JabRef#181. Please find the build at https://builds.jabref.org/fixEditorFreeze/.

You can just checkout the branch or add bartsch's fork as additional git remote for fetching.

@grimes2
Copy link
Contributor Author

grimes2 commented Nov 2, 2016

JabRef 3.7-dev--snapshot--2016-11-02--fixEditorFreeze--d1c1801
windows 10 10.0 amd64
Java 1.8.0_111

Thanks for the build. With the tested build the bug is fixed. Thanks for the fix and the improvement of the entry editor code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants