Fix editor freeze #2225
Merged
Fix editor freeze #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tobiasdiez
added
the
status: ready-for-review
koppor
approved these changes
Nov 3, 2016
| if (visName != null) { | ||
| entryEditor.setVisiblePanel(visName); | ||
| } | ||
| splitPane.setBottomComponent(entryEditor); | ||
|
|
||
| if (divLoc > 0) { |
There was a problem hiding this comment.
The height of the editor (or preview) is handled by the BasePanel#adjustSplitter() method which just sets the saved height.
The height of the preview panel is saved in BasePanel#saveDividerLocation() without any maximum/minimum size adjustment. Currently the minimum size of the preview panel is 5px.
The entry editor height is saved in 3 places without any adjustments, but the minimum height of the editor is limited via the editor toolbar and the layout of the tabs (which depends on the entry type) .
|
For @grimes2, this fixed the issue. My issue is also fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes: #2220.
Mainly I removed
SwingUtilities.invokeLater(() ->. I also added some lines to remove the event listener from the old entry editors.