Refactor EntryEditor & EntryEditorTab

[chriba]

I refactored many comments (some of them even referred to variables which do not exist anymore).
I removed some unused Methods, replaced some code with already existing methods and refactored a switch-case.

[tschechlovdev]

Please fix codacy. Beside the minor comments it's good from my side.

[tschechlovdev]

I think the comment can be deleted.

[chriba]

done

[tschechlovdev]

This can be also deleted I think. Or you could replace it to not point to the bug.

[chriba]

done

[grimes2]

In the prompt Firstname Lastname... "others" is not translated. My proposal is to replace it by "et al.". This is international, so no translation needed.
prompt = String.format("%1$s and %1$s and others", Localization.lang("Firstname Lastname"))
->prompt = String.format("%1$s and %1$s and et al.", Localization.lang("Firstname Lastname"))

For the month field in BibLaTeX mode MM (1-12) is recommended, but also #mmm# (#jan#) is allowed for backward compatibilty to BibTeX. BibTeX mode only recommends #mmm#. So my proposal:
MM or #mmm#

[stefan-kolb]

Why is this removed here? If I remember this right this was needed to distinguish optional fields from fields that are displayed in the other fields tab?

[chriba]

Items of the list are never used, only added to it (displayedOptionalFields was only used in line 234, 240, 244, and 245; or am I missing something?)

[koppor]

and others is the bibtex string to procude et al. using bibtex/biblatex Therefore, this must not be translated. It is contained in the help to educate users to use this string.

[chriba]

Changed the prompt for Month-field.
I don't know about the prompts for the other fields, maybe you can point me into the right direction?

[grimes2]

From my side it looks ok now. I misinterpreted the author... prompt, because I didn't know the function of and others in BibTeX author/editor field. I found this documented in the official specification "Bibtexing".

[grimes2]

Just one small addition. I found following person name fields for BibLaTeX:

private static final List<String> BIBLATEX_PERSON_NAME_FIELDS = Arrays.asList(FieldName.AUTHOR, FieldName.EDITOR,
            FieldName.EDITORA, FieldName.EDITORB, FieldName.EDITORC, FieldName.TRANSLATOR, FieldName.ANNOTATOR,
            FieldName.COMMENTATOR, FieldName.INTRODUCTION, FieldName.FOREWORD, FieldName.AFTERWORD,
            FieldName.BOOKAUTHOR, FieldName.HOLDER, FieldName.SHORTAUTHOR, FieldName.SHORTEDITOR, FieldName.SORTNAME,
            FieldName.NAMEADDON, FieldName.ASSIGNEE);

I assume that the suggestion syntax
return String.format("%1$s and %1$s and others", Localization.lang("Firstname Lastname"));
is valid for all the mentioned fields above. What do you think? Should we add the missing person name fields to the switch construction?
Exception: nameaddon is a field (literal) not a list (name)

[chriba]

Now I reuse the already existing lists.

[tobiasdiez]

LGTM

[koppor]

This PR breaks Ctrl + A. See #2615