-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The generated BibTeX keys of two different imported entries are not unique?!! #2687
Comments
Thank you for your report, I can confirm this with current master 9205a02. |
I had a look in the code and infact JabRef does not enforce unique bibtex keys for entries. Possible fix: org.jabref.gui.Basepanel.insertEntry() (line 1180) should check for duplicate keys and automatically append a letter to the bibtex key. Other fix: When importing entries using a fetcher automatically generate a key with the JabRef Key generator. @JabRef/Developers what do you think about this matter? |
I would say that the fetcher should automatically generate a new key, since the key delivered from the fetchers is often meaningless / adheres to the convention of the provider not the user. |
I did the import with a snapshot from 7 days ago. It work well using the new entry->DOI ->generate way. |
I tried http://dx.doi.org/10.1103/PhysRevB.87.195439 and http://dx.doi.org/10.1103/PhysRevB.87.205427. The BibTeX there have different keys. @alshehab211 could you state how you imported the entries, please? |
@koppor uhm? Have you tried to download them via the new entry dialog? For me this is still as @alshehab211 reports it. |
@koppor using the New BibTex entry in Jabref with ID type: DOI |
@bernhard-kleine Yes, the two entries are not identified as duplicates but JabRef import them with the same BibTeX keys. |
So short poll which solution from #2687 (comment) should be implemented:
|
This problem is arising when the first author has more than an article in the same year?! |
@alshehab211 Not particularly. We use a fetcher which at the moment just copies the key from the database which is queried. If this database contains any duplicate keys they are imported as they come. |
@lynyus which database? if you can see the pages also are not imported for the mentioned entries?! (10.1103/PhysRevB.87.195439 & 10.1103/PhysRevB.87.205427) although the pages no. present in the BibTex in the journal database?! |
@alshehab211 it's from doi.org, nevertheless, when we call the download method in DoiFetcher#55, the entry already has the other key format. |
When will the updated version of jabref be released where this error is fixed? |
We have not yet a clear roadmap for the release of 4.0. Since a lot has changed in the new version, we will probably release an alpha / beta version first. Until then you may try out the latest development version from http://builds.jabref.org/master/, but please be aware that this version might have some issues and prepare accordingly with backups of your bib files etc. |
JabRef version 3.8.2 on Windows 7
Steps to reproduce:
10.1103/PhysRevB.87.195439
10.1103/PhysRevB.87.205427
10.1209/0295-5075/102/27001
The text was updated successfully, but these errors were encountered: