-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The identical paper is not recognized as duplicate #2708
Comments
Maybe related to #2687 @lynyus Maybe you have an idea |
Maybe, but the difference to that issue is that the papers there are not identical while here it is the very same paper Jabref acted upon as not identical. The question here what makes them not duplicates, there why are the PhysRev not distinguished. Maybe in both cases what makes paper similar or dissimilar. |
@bernhard-kleine Can you post the BibTeX code for both entries please. |
Crossref:
vs. Pubmed:
Problem seems to be that |
Sorry for being late I thought the answer from matthias was sufficient. By the way you should add .bib to the list of uploadable file types. |
Ok, so here is an evaluation of the scenario. The two entries were not considered equal because:
To fix this we need to implement a better duplicate algorithm which is not that easy and a lot of work. For this case i have added a step that checks if an identifier like the DOI is equal and considers them equal immediately. |
Thank you for your report 👍 |
Unfortunate, now there is an issue with unrelated entries identified as duplicates. |
@stefan-kolb Can you please check again? |
@bernhard-kleine Are you running the latest dev version? There was one version where the ISSN was classified as identifier before but only the DOI, PUBMED and EPRINT are remaining now. 766e555 |
On 4. April 2017 22:53:52 MESZ, Stefan Kolb <notifications@github.com> wrote:
|@bernhard-kleine Are you running the latest dev version? There was one
|version where the ISSN was classified as identifier before but only the
|DOI, PUBMED and EPRINT are remaining now.
|766e555
|
|--
|You are receiving this because you were mentioned.
|Reply to this email directly or view it on GitHub:
|#2708 (comment)
I downloaded the actual master of today.
--
Diese Nachricht wurde von meinem Mobiltelefon mit Kaiten Mail gesendet.
|
Well, there is no actual master of today as every commit reflects itself in a new build. |
On 4. April 2017 23:43:41 MESZ, Stefan Kolb <notifications@github.com> wrote:
|Well, there is no actual master of today as every commit reflects
|itself in a new build.
|Unfortunately, I cannot reproduce this for the latest build.
|
|--
|You are receiving this because you were mentioned.
|Reply to this email directly or view it on GitHub:
|#2708 (comment)
I will try again tomorrow.
--
Diese Nachricht wurde von meinem Mobiltelefon mit Kaiten Mail gesendet.
|
JabRef 4.0.0-dev--snapshot--2017-04-04--master--b71420628 (from today) and master--766e555c0 (from 16:11 yesterday) |
@stefan-kolb As I thought it already might be solved by your changes I've checked it before re-opening the issue with JabRef_4_0_0-dev--snapshot--2017-04-04--master--b71420628. |
@bernhard-kleine Should be fixed in now in the latest dev builds. |
With the latest update only duplicates were found which were real duplicates. Thanks for your efforts. It is much appreciated. |
* upstream/master: fix ID consideration in DuplicateCheck Add ArXiv identifier batch lookup (#2710) Update mockito from 2.7.19 to 2.7.21 More defensive identifier list #2708 Revert "Add more identifier field names #2708" Add more identifier field names #2708 Consider entries as equal if their DOI matches #2708 Imports Imports Move duplicate detection to logic Reuse edit distance class Refactoring EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709) Add changelog entry Increase permitted size of StringUtil Make sure that JavaFx shuts down in case another JabRef instance is already open
* upstream/master: (35 commits) Update antlr from 4.6 to 4.7 Fix build fix ID consideration in DuplicateCheck Add ArXiv identifier batch lookup (#2710) Update mockito from 2.7.19 to 2.7.21 More defensive identifier list #2708 Revert "Add more identifier field names #2708" Add more identifier field names #2708 Consider entries as equal if their DOI matches #2708 Imports Imports Move duplicate detection to logic Reuse edit distance class Refactoring EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709) Add changelog entry Increase permitted size of StringUtil Make sure that JavaFx shuts down in case another JabRef instance is already open Remove obsolete localization strings Hide context menu before group edit/add (probably a JavaFX vs Swing problem) ... # Conflicts: # src/main/java/org/jabref/gui/groups/GroupTreeController.java # src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
JabRef 4.0.0-dev--snapshot--2017-04-03--master--b45575649
Windows 7 6.1 amd64
Java 1.8.0_121
Steps to reproduce:
0. open PMID 21497511 on Pubmed
This is indeed very strange. I wonder what Jabref now considers as duplicate of an entry.
The text was updated successfully, but these errors were encountered: