Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not save file... Error in field '...': Braces don't match #3167

Closed
MarioHoberg opened this issue Aug 29, 2017 · 8 comments
Closed

Could not save file... Error in field '...': Braces don't match #3167

MarioHoberg opened this issue Aug 29, 2017 · 8 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor export / save
Milestone

Comments

@MarioHoberg
Copy link

MarioHoberg commented Aug 29, 2017

I am using JabRef 4.0 beta3, so i guess #2995 is merged, this issue is identical to #2993.

I am using a shared (PostgreSQL) database and have the "Automatically save the library to" option enabled.

When starting to enter a brace { into a field I get an error dialog that sais:

Save library
Could not save file...
Error in field '...': Braces don't match.

When I disable "Automatically save the library to" this is not an issue.
Also there is a latency while typing.
Maybe you should only sync when leaving the field and not on every keystroke?

@lenhard
Copy link
Member

lenhard commented Aug 30, 2017

@MarioLipinski Thanks for your report.

You've already linked the right issue and PR above. This fixes the same problem for local files, but it seems that shared databases need extra attention.

I think I've found the problem and fixed it (by applying the same solution as we have for local databases). But I haven't worked with the shared database feature before and I have no way of testing this properly. So you'll have to help me a little here. Could you please install the latest build from http://builds.jabref.org/master/ and let me know if the error message is gone?

@MarioHoberg
Copy link
Author

Just tried JabRef_windows-x64_4_0-dev--snapshot--2017-08-30--master--07edf68fc.exe. Unfortunately I still get the error messages and typing is still slow:

grafik

@LinusDietz LinusDietz added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 31, 2017
@LinusDietz
Copy link
Member

LinusDietz commented Aug 31, 2017

Can confirm this with current master 6f1fda1 and NO sql database

@LinusDietz LinusDietz added this to the v4.0 milestone Aug 31, 2017
@lenhard
Copy link
Member

lenhard commented Aug 31, 2017

Ok, I see. I've done one more try (and accidentally commited directly to master again). @MarioLipinski @lynyus Please try out the latest build from http://builds.jabref.org/master/ currently JabRef-4.0-dev--snapshot--2017-08-31--master--54e0994ba

If this doesn't work, I give up.

@LinusDietz
Copy link
Member

@lenhard sorry, still doesn't do the job:
In 3.8.2 you could not close the entry editor when there were unmatched braces. This is possible now.

@lenhard
Copy link
Member

lenhard commented Aug 31, 2017

Ok, strangely it works for me locally.

As I've written above: I give up. Lately, I am spending way too much time trying to fix bugs that others have introduced by merging very premature features.

Siedlerchr pushed a commit that referenced this issue Sep 12, 2017
* Add braces on closing entry editor

* Fix checkstyle

* Fix reassignment of parameter

* added tests and incorporated reviewer feedback

* Fix formatting
@LinusDietz
Copy link
Member

Thanks to @snisnisniksonah, we finally have a solution for this. Check out the latest build from http://builds.jabref.org/master/ if it works for you.

Siedlerchr added a commit that referenced this issue Sep 13, 2017
* upstream/master:
  Localization: French: Translation of a new string (#3212)
  Fix #2775: Hyphens in last names are properly parsed (#3209)
  Followup to Issue #3167 (#3202)
  Update mockito-core from 2.9.0 -> 2.10.0
@MarioHoberg
Copy link
Author

I am still seeing this issue with current master.

When I open Jabref, Use File -> Connect to shared database and enable 'Automatically save the library to', I am still seeing this issue.
If I close Jabref and reopen, the local file is opened instead but automagically it is still synced to the database (a bit scary though). Then I do not see the errors.

In any case, typing in the text fields is a nightmare caused by a huge delay between pressing a key and the character appearing in the text input.

(btw. there is a translation error for German for the menu entry 'Connect to shared database')

Siedlerchr added a commit that referenced this issue Sep 23, 2017
* upstream/master: (188 commits)
  Show file description only if not empty
  Add file description to gui and fix sync bug (#3210)
  Don't highlight odd rows in file list editor (#3223)
  Fix assertion by removing typo (#3220)
  Update assertion to change of online reference (#3221)
  Put in null return
  Reformatted code, renamed method, added try/catch
  Add tests for removal changes
  Improve telemetry (#3218)
  Real test linking real other entry (#3214)
  Check for explicit group at different location
  Update java-string-similarity from 0.24 -> 1.0.0
  Only remove ExplicitGroups from entries, but not keyword-based groups
  Localization: French: Translation of a new string (#3212)
  Fix null return
  Changed from Path to Optional<Path>
  Fix #2775: Hyphens in last names are properly parsed (#3209)
  Followup to Issue #3167 (#3202)
  Remove unused import in GroupTreeNode
  Move getEntriesInGroup to GroupTreeNode
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor export / save
Projects
None yet
Development

No branches or pull requests

4 participants