Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor change] Fix assertion failure due to change of online reference #3221

Merged
merged 1 commit into from
Sep 15, 2017
Merged

[minor change] Fix assertion failure due to change of online reference #3221

merged 1 commit into from
Sep 15, 2017

Conversation

sammann-fnordkollektiv
Copy link

It seems as if the on-line reference changed by adding an author's first name.
Hence field "author" and "url" were updated to match our assertion again.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

It seems as if the online reference changed and added an author's firstname. Hence field "author" and "url" were updated to match assertion again.
@Siedlerchr
Copy link
Member

Thanks for your contributions!

@Siedlerchr Siedlerchr merged commit 5a9fc21 into JabRef:master Sep 15, 2017
Siedlerchr added a commit that referenced this pull request Sep 19, 2017
* upstream/master:
  Don't highlight odd rows in file list editor (#3223)
  Fix assertion by removing typo (#3220)
  Update assertion to change of online reference (#3221)
  Put in null return
  Reformatted code, renamed method, added try/catch
  Fix null return
  Changed from Path to Optional<Path>
  Added logic to check whether linked file already exists
Siedlerchr added a commit that referenced this pull request Sep 23, 2017
* upstream/master: (188 commits)
  Show file description only if not empty
  Add file description to gui and fix sync bug (#3210)
  Don't highlight odd rows in file list editor (#3223)
  Fix assertion by removing typo (#3220)
  Update assertion to change of online reference (#3221)
  Put in null return
  Reformatted code, renamed method, added try/catch
  Add tests for removal changes
  Improve telemetry (#3218)
  Real test linking real other entry (#3214)
  Check for explicit group at different location
  Update java-string-similarity from 0.24 -> 1.0.0
  Only remove ExplicitGroups from entries, but not keyword-based groups
  Localization: French: Translation of a new string (#3212)
  Fix null return
  Changed from Path to Optional<Path>
  Fix #2775: Hyphens in last names are properly parsed (#3209)
  Followup to Issue #3167 (#3202)
  Remove unused import in GroupTreeNode
  Move getEntriesInGroup to GroupTreeNode
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants