Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When PDF file is highlighted without any comment, File annotations display "N/A", it is better to leave it empty #3280

Closed
psychelzh opened this issue Oct 9, 2017 · 7 comments
Closed

When PDF file is highlighted without any comment, File annotations display "N/A", it is better to leave it empty #3280

psychelzh opened this issue Oct 9, 2017 · 7 comments
Labels
external files type: enhancement ui

Comments

@psychelzh
Copy link
Contributor

JabRef version 4.0 on Windows 10

Just as the following screenshot, N/A seems a little intrusive for users.

na
@psychelzh
Copy link
Contributor Author

psychelzh commented Oct 9, 2017 •
edited
Loading

And on the left panel, I do think it is best to display the so-called Marking, and try to remove CRLF/\n/\r's from the Marking content.

@PammyS
Copy link

PammyS commented Oct 11, 2017

@psychelzh @tobiasdiez I'll be happy to take this. Please assign it to me

@tobiasdiez
Copy link
Member

@PammyS nice to hear! If you have any questions, feel free to ask here. I can't assign you to this issue since you have not made any contribution before.

stefan-kolb added a commit that referenced this issue Oct 11, 2017
@stefan-kolb
Resolves #3280 Empty String instead of N/A
dba3b7a
@stefan-kolb stefan-kolb mentioned this issue Oct 11, 2017
Merged
@LinusDietz
Copy link
Member

I am not sure if we can remove these line breaks from the extracted markings, as it is quite unclear if they come from line break in the paper or from a new paragraph... However, who has a marking spanning several paragraphs or headings?

@psychelzh
Copy link
Contributor Author

psychelzh commented Oct 11, 2017 •
edited
Loading

I tend to suggest that the line breaks can be safely removed. Just as you put, few people will try to mark several paragraphs; and if so, they can also be merged, can't they? @lynyus

tobiasdiez pushed a commit that referenced this issue Oct 12, 2017
@stefan-kolb @tobiasdiez
Resolves #3280 Empty String instead of N/A (#3288)
9eab9ee
@tobiasdiez
Copy link
Member

The N/A string is now removed, but the line breaks of the marking are still there. By the way, in #3285 I added a new formatter that removes line breaks. So one just needs to run it on the marking.

@tobiasdiez tobiasdiez reopened this Oct 12, 2017
@psychelzh
Copy link
Contributor Author

psychelzh commented Oct 12, 2017 •
edited
Loading

Did you mean that users can remove the line breaks mannually in future releases? But how can that be done?

stefan-kolb added a commit that referenced this issue Oct 12, 2017
@stefan-kolb
Remove newlines from file annotaion contents #3280
288a328
@stefan-kolb stefan-kolb mentioned this issue Oct 12, 2017
Merged
Siedlerchr added a commit that referenced this issue Oct 19, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into exportPdf
95474ea 
* upstream/master:
  Update gradle to 4.2.1 (#3322)
  Avoid recreation of the EntryEditor (#3187)
  Fix #3133 telemetry by locking azure to 1.0.9
  German translation for missing properties (#3312)
  Improvement for Java FX font rendering on Linux (#3305)
  Add also conversion for em dash
  Add \textendash to the html conversion table
  Update latex2tunicode from 0.2.1 -> 0.2.2
  Added note about updating controlsfx
  Fix exception/freezing on EntryChangedEvent in Entry Editor (#3299)
  Update libs (#3300)
  update guava from 23.0 -> 23.2
  update mvvmfx-validation from 1.6.0 -> 1.7.0
  Resolves #3255 file open dialog should have "supported formates" filetype
  Fix #3235: remote metadata is updated instead of delete + insert (#3282)
  Change OO paths to Libre Office in preferences (#3287)
  Fix #2471: remove line breaks from abstracts in ADS fetcher (#3285)
  Resolves #3280 Empty String instead of N/A (#3288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external files type: enhancement ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@LinusDietz @lenhard @stefan-kolb @tobiasdiez @PammyS @psychelzh