Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception/freezing on EntryChangedEvent in Entry Editor #3299

Merged
merged 2 commits into from
Oct 14, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 13, 2017

Fixes #3294 Digging down in the log file I found that the problem is that the sourceTab.update is not executed in the FXThread. This could also be

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 13, 2017
@lenhard
Copy link
Member

lenhard commented Oct 14, 2017

Let's wait for @g-mos to confirm that this PR fixes the issue and then we can merge.

@g-mos
Copy link

g-mos commented Oct 14, 2017

It seems to have fixed the issue, you can merge it.

@matthiasgeiger
Copy link
Member

Great!

@matthiasgeiger matthiasgeiger merged commit 137c448 into master Oct 14, 2017
@tobiasdiez tobiasdiez deleted the mergeFreeze branch October 15, 2017 02:01
Siedlerchr added a commit that referenced this pull request Oct 19, 2017
* upstream/master:
  Update gradle to 4.2.1 (#3322)
  Avoid recreation of the EntryEditor (#3187)
  Fix #3133 telemetry by locking azure to 1.0.9
  German translation for missing properties (#3312)
  Improvement for Java FX font rendering on Linux (#3305)
  Add also conversion for em dash
  Add \textendash to the html conversion table
  Update latex2tunicode from 0.2.1 -> 0.2.2
  Added note about updating controlsfx
  Fix exception/freezing on EntryChangedEvent in Entry Editor (#3299)
  Update libs (#3300)
  update guava from 23.0 -> 23.2
  update mvvmfx-validation from 1.6.0 -> 1.7.0
  Resolves #3255 file open dialog should have "supported formates" filetype
  Fix #3235: remote metadata is updated instead of delete + insert (#3282)
  Change OO paths to Libre Office in preferences (#3287)
  Fix #2471: remove line breaks from abstracts in ADS fetcher (#3285)
  Resolves #3280 Empty String instead of N/A (#3288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants