Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect RIS fields #3634

Closed
dsifford opened this issue Jan 13, 2018 · 5 comments
Closed

Incorrect RIS fields #3634

dsifford opened this issue Jan 13, 2018 · 5 comments

Comments

@dsifford
Copy link

Greetings.

I'm the developer of the Academic Blogger's Toolkit plugin for WordPress and some of my users were having difficulty importing RIS from jabref. Upon further investigation, it looks like you are currently mis-keying some fields.

} else if ("A2".equals(tag) || "A3".equals(tag) || "A4".equals(tag)) {
if (editor.isEmpty()) {
editor = value;
} else {
editor += " and " + value;
}

According to the RIS specification, A1-A4 are exclusively author fields. Only the ED field should be used for editors.

Related: dsifford/academic-bloggers-toolkit#409 (comment)

@dsifford
Copy link
Author

Also, while I have your attention. It appears that your RIS exporter is leaving tons of blank lines (ostensibly where optional fields were skipped).

Here's an example that I just tried:

TY  - BOOK
AU  - Smith, Bob
AU  - Doe, Jan
AU  - Brown, Judy
A2  - Martin, Steve
A2  - Clark, Joe
T1  - Testing Book Title
PB  - Test Publisher

Y1  - 2015/october
VL  - 1












ER  -

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs import export / save labels Jan 13, 2018
@lenhard
Copy link
Member

lenhard commented Jan 13, 2018

Thanks for reporting! This shouldn't be too hard to fix.

Related issue: #2607

@dsifford
Copy link
Author

Sure thing. Happy to help.

Here's the list of field mappings that I use for RIS files:

https://github.com/dsifford/astrocite/blob/668a9e4a0cb15a21a310d38e6e3f9ec5af7db9a0/packages/astrocite-ris/src/constants.ts#L62-L107

Also...

"stateful" fields: https://github.com/dsifford/astrocite/blob/668a9e4a0cb15a21a310d38e6e3f9ec5af7db9a0/packages/astrocite-ris/src/parser.ts#L58-L65

and finally, these:

https://github.com/dsifford/astrocite/blob/master/packages/astrocite-ris/src/parser.ts#L90-L109

The above fields include the standardized fields that you'd expect, but also non-standard (but highly used) fields that I've seen other applications export into (e.g., Zotero, Endnote, etc).

Hope that's useful!

@lenhard
Copy link
Member

lenhard commented Jan 21, 2018

The import-related problems described in this issue should be fixed by #3642. The export-related formatting issues are still present, but since this is about formatting and not functional correctness, I'll reclassify this issue from bug to enhancement.

@lenhard lenhard added type: enhancement and removed bug Confirmed bugs or reports that are very likely to be bugs labels Jan 21, 2018
@lenhard
Copy link
Member

lenhard commented Jan 24, 2018

The blank lines in the export are now resolved as well by #3661

So, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants