Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Incorrect error message stops plugin from working #409

Closed
gconyers opened this issue Jan 8, 2018 · 11 comments
Closed

Incorrect error message stops plugin from working #409

gconyers opened this issue Jan 8, 2018 · 11 comments

Comments

@gconyers
Copy link

gconyers commented Jan 8, 2018

ABT Version: 4.13.0-beta.1

PHP Version: 5.5.38

Make Plus:

Plugin List:

  • ABT
  • Contact Form 7
    -Disqus
  • Edit Flow
  • Exec- PHP
  • Google Analytics for WP
  • Jetpack
  • Make Plus
  • Participant's Database
  • Popup Ally
  • Re-add text underline and justify
  • Sensei
  • WooCommerce

Browser: Google Chrome (Version: 63.0.3239.108)

The plugin to accept the date since it's in the format it asks for.

**The plugin didn't accept the date format.
screenshot
**

Console messages:

// Paste messages here
@dsifford
Copy link
Owner

dsifford commented Jan 8, 2018

Sorry about that. The fix for this has not been released to wordpress.org because I haven't had time to test it thoroughly, but you can download a beta version from here if you're okay with that: https://github.com/dsifford/academic-bloggers-toolkit/releases/tag/v4.13.0-beta.1

@gconyers
Copy link
Author

gconyers commented Jan 8, 2018 via email

@mjluser1
Copy link

mjluser1 commented Jan 13, 2018

I also am having this problem and am having to use a work-around. I import my .ris database, so I export a new reference from JabRef to the clipboard and then paste it into my .ris database that is open in Notepad++ and clean it up for importing (no blank lines and remove Jabref unique fields). Then I have the new references available for new posts and pages. However, I cannot add them to existing posts and pages without deleting all references and reimporting. I write academically and use many references. Please as soon as possible test your beta fix and make it available. You have done a fantastic job creating this plugin and it much appreciated. Thanks!.

@dsifford
Copy link
Owner

@mjluser1 Sorry to hear you're running into issues.

Can you clarify what exactly is causing trouble for you? Is it the date fields as described in the issue description, or is it importing RIS from jabref?

If the issue has to do with the imported file, can you attach an example file that I can try?

Finally, if you could provide a set of step-by-step instructions for how to trigger the issue you're running into, that would be very helpful.

@mjluser1
Copy link

mjluser1 commented Jan 13, 2018 via email

@mjluser1
Copy link

mjluser1 commented Jan 13, 2018

Also, I just discovered JabRef exports the Editor field to .ris identified as A2. Then your plugin ABT identifies it as a second author. So I am going to have to hand-craft entries with editors either before or after import. How can I get a list of field ids ABT uses? Then I can check in Notepad++ to change field names as necessary. Thanks!

EDIT: I discovered an easier way. JabRef allows custom export filters, and the .ris filter also does not export the Series title for a book. I would like to customize the .ris filter so that it imports directly into ABT without any cleaning of blank lines and has your expected field ids.

@dsifford
Copy link
Owner

Yikes! I don't want you or other users to have to go through that to get jabref to cooperate with ABT. I'll take a look at jabref's RIS implementation and see if I can reasonably align mine with theirs (or, if theirs is too non-standard, I'll see if I can at the very least catch it in those scenarios).

The file parsing is done in a separate project of mine. The list of mapped fields for RIS can be found here.

Also, I'll work on adding support for blank lines so you won't have to manipulate the JabRef export in notepad prior to importing.

@dsifford
Copy link
Owner

dsifford commented Jan 13, 2018

Of note: I currently skip A2 fields because they are non-standard. So it would be trivial to add that one in.

Scratch that. They aren't currently skipped.

@dsifford
Copy link
Owner

@mjluser1 I just downloaded jabref and tried importing a bibtex entry that I created and it seemed to work fine. Have you tried importing bibtex or have you just tried RIS?

@dsifford
Copy link
Owner

Fixed the broken RIS importer here: https://github.com/dsifford/astrocite/releases/tag/v0.10.0

You should be able to import jabref RIS files in the next release.

@dsifford
Copy link
Owner

Fixed in v4.13.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants