possible problem with RIS publication year

[CodeSJS]

JabRef version on

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behavior:

1. ...import ris file (control i)

Please see the attached ris.gz file. Using either JabRef 4.3.1 or dev-5.0, JabRef imports publication year as 2019, when it is really 2005.

At first I thought it was a problem with the journal (J. Chem. Phys.) web site. Then I saw that the Y1 and PY fields in the ris file were correctly set to 2005. The Y2 field is 2019, but that is supposed to be the access date.

The bib file works fine, since it does not contain a field for access date.

Please let me know if the problem is really with the journal after all, and I'll communicate with them.

Thanks for JabRef!

Log File

Paste an excerpt of your log file here

[Siedlerchr]

@CodeSJS Thanks for your report. Unfortuantely here is no attached file visible. Could you please add this?

[CodeSJS]

My apologies. I thought I dragged gzipped files into the right window. I'm new to github. I've attached gzipped ris and bib files to this email. In the ris file, the PY and Y1 fields are both 2005, yet JabRef imports as 2019, which is the Y2 field. Thanks, Sherwin On 3/28/19 7:24 AM, Christoph wrote: @CodeSJS<https://github.com/CodeSJS> Thanks for your report. Unfortuantely here is no attached file visible. Could you please add this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#4816 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AlCPNDs94S1e_40K8OnCeosQg6YUlxk5ks5vbKYygaJpZM4cO5af>.

…

-- Sherwin Singer Department of Chemistry and Biochemistry Ohio State University 100 W. 18th Ave. Columbus, OH 43210 614-292-8909 www.asc.ohio-state.edu/singer.2<http://www.asc.ohio-state.edu/singer.2>

[CodeSJS]

Hmm, I'm still not sure files are attached. I'm trying again.
Sherwin

aip_jcp123.bib.gz
aip_jcp123.ris.gz

[Siedlerchr]

@CodeSJS Thanks! You can only add files to an issue here at github, replying via mail with attachments does not work.

I could confirm the behaviour.
When I add the entry via DOI doi:10.1063/1.1954747 I get the correct date 2005.

[Siedlerchr]

Should be fixed now in the latest master, the first valid year found is now taken and no longer overwritten.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

[CodeSJS]

Thanks for working on this.

The import is now correct for the example I supplied, but it may not be a solid fix. If for some reason the Y2 field precedes Y1 or PY, then I confirmed that the JabRef development master still gets the publication year wrong.

Y2 is access year, should never be imported as publication year, so I guess JabRef should ignore this field. PY, publication year, should be the desired field. Y1 is "primary date". I searched, but could not find out how primary date differs from publication year, other than is a full year-month-day.

Regards,
Sherwin

[Siedlerchr]

@CodeSJS JabRef checks multiple fields for dates:
Y1, Y2, PY, DA
with my fix the first found date in one of the fields is taken.

I looked and found that the original code was adapted for compatibility with a word press plugin #3634 from @dsifford

Y1 and PY seem to be synonyms.
Y2 should be date-accessed or sth simliar, agree that this should be removed.
DA is another date field, but I have no idea for what it is used.
https://en.wikipedia.org/wiki/RIS_(file_format)

jabref/src/main/java/org/jabref/logic/importer/fileformat/RisImporter.java

Lines 196 to 206 in 40600b3

	} else if (!foundDate && (("Y1".equals(tag) || "Y2".equals(tag) || "PY".equals(tag) || "DA".equals(tag)) && (value.length() >= 4))) {
	String year = value.substring(0, 4);
	try {
	Year.parse(year, formatter);
	//if the year is parsebale we have found our date
	fields.put(FieldName.YEAR, value.substring(0, 4));
	foundDate = true;
	} catch (DateTimeParseException ex) {
	//We can't parse the year, we ignore it
	}

[Siedlerchr]

Thanks to @victorjof this issue should be already fixed in master