Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

":PDF" will not show the pdf icon in the #6169

Closed
1 task done
ShuguangSun opened this issue Mar 23, 2020 · 9 comments · Fixed by #6264
Closed
1 task done

":PDF" will not show the pdf icon in the #6169

ShuguangSun opened this issue Mar 23, 2020 · 9 comments · Fixed by #6264
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Milestone
v5.1

Comments

@ShuguangSun
Copy link

ShuguangSun commented Mar 23, 2020 •
edited
Loading

JabRef version JabRef 5.1--2020-03-10--43f533b on Windows 10 10.0 amd64 Java 13.0.2

Steps to reproduce the behavior:

  1. Add a file to General => File, which will add a file field looking like
    file = {:STAT/aa.pdf:PDF},
  2. It will show an unrecognized file type icon in the linked files column instead of the pdf type icon (although it will open the pdf file using the proper reader)
  3. Change it to file = {:STAT/aa.pdf:pdf},, the pdf type icon will be shown.
@Siedlerchr
Copy link
Member

Thanks for your report, looks like this was missed in #6119

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs ui labels Mar 23, 2020
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 23, 2020
@tobiasdiez tobiasdiez added this to the v5.1 milestone Mar 25, 2020
@leitianjian
Copy link
Contributor

Hi, We're a team of 5 students currently attempting to make our first open-source contribution, and we want to firstly work on this bug

We have reproduced this bug successfully. Because it is our first time trying to participate in this project. I would be grateful if any hint can be provided. And I am trying to get more familiar with this project. A question is, how long could we take to fix this bug?

@Siedlerchr
Copy link
Member

Thanks for your interest in contributing to JabRef!
Please follow our contribution guide https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md

There is no hurry in finishing. Take your time to make yourself familiar with the code. Just create a PR with your changes early on, so we can provide constant feedback.
Code wise, as a hint you should check the pr I linked in the comments which probably introduced this bug

@leitianjian
Copy link
Contributor

Ok, I will check the material carefully.

"Just create a PR with your changes early on" means that we can create a PR before we fix the bug and let you know our progress or comment on our code?
Thanks for your reply, I will check the PR you linked carefully

@dimitra-karadima
Copy link
Contributor

@leitianjian Yes! You can create a PR even if you haven't fixed the bug in order to get a feedback on your code! Check the draft PRs: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@leitianjian
Copy link
Contributor

@dimitra-karadima Thanks for your reply and sorry for my late comment. I am working on it, If there are some difficulties I cannot solve, I will create a PR and get some feedback

@leitianjian leitianjian mentioned this issue Apr 8, 2020
Merged
5 tasks
@leitianjian
Copy link
Contributor

Hi, I have fixed the bug of the icon. Please check my draft pull request, thanks

@tobiasdiez
Copy link
Member

tobiasdiez commented Apr 14, 2020 •
edited
Loading

See also my comment in #6264

@tobiasdiez
Copy link
Member

Thanks to @leitianjian (and his crew) this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@leitianjian leitianjian mentioned this issue Apr 28, 2020
Merged
5 tasks
koppor pushed a commit that referenced this issue Sep 15, 2022
Squashed 'buildres/csl/csl-styles/' changes from 8d69f16..201e022
df558ab 
201e022 Update trends-journals.csl (#6224)
46e6eed Update nottingham-trent-university-library-harvard.csl (#6220)
684bb48 Update politix.csl (#6199)
c484b0b Update mcgill-fr.csl (#6198)
cbcf2f2 Update mary-ann-liebert-vancouver.csl (#6218)
47174f0 Create journal-of-dairy-research.csl (#6195)
fdd1eac Update harvard-anglia-ruskin-university.csl (#6196)
9e384d6 Create estonian-journal-of-earth-sciences.csl (#6194)
afba9b7 Delete moore-theological-college.csl as per university (#6197)
644549f Create acta-medica-philippina.csl (#6192)
6566114 Update rassegna-degli-archivi-di-stato.csl (#6186)
3509a2f Update universidade-federal-de-sergipe-departamento-de-engenharia-de-… (#6187)
de4845f Update mary-ann-liebert-vancouver.csl (#6213)
16828b6 Update ucl-university-college-apa.csl (#6172)
c08613b Update ucl-university-college-harvard.csl (#6173)
028bad4 Create sociologia-ruralis.csl (#6170)
77d428c Update journal-of-plankton-research.csl (#6169)
92e1022 Update and rename dependent/journal-of-the-national-cancer-institute.… (#6168)
120efb1 Update journal of hearing science
e503477 Create new-harts-rules-the-oxford-style-guide-author-date.csl (#6163)
49ab318 Create the-depositional-record.csl (#6159)
f4f6920 Update and rename laser-and-photonics-reviews.csl to dependent/laser-… (#6165)
d8ca4bc Update united-states-international-trade-commission.csl (#6162)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 201e022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Bugs
Archived in project
Milestone
v5.1
Development

Successfully merging a pull request may close this issue.

Showing correct icon on main table linked files column leitianjian/jabref
5 participants
@Siedlerchr @ShuguangSun @tobiasdiez @leitianjian @dimitra-karadima