Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store downloaded file if it is already attached #6197

Closed
koppor opened this issue Mar 28, 2020 · 5 comments · Fixed by #7702
Closed

Do not store downloaded file if it is already attached #6197

koppor opened this issue Mar 28, 2020 · 5 comments · Fixed by #7702
Labels
external files good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@koppor
Copy link
Member

koppor commented Mar 28, 2020

Follow-up to #6174

When a user downloads a PDF - and this PDF equals to an already attached PDF, it should not be attached again.

Possible steps:

  1. default.pdf exists
  2. Download as default (1).pdf.
  3. Check if file content of default.pdf equals file content of default (1).pdf (Use https://guava.dev/releases/21.0/api/docs/com/google/common/io/Files.html#equal-java.io.File-java.io.File-)
  4. If it is equal, just delete default (1).pdf. Show notification that already linked. Finish.
  5. If not equal, add to linked files.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@koppor
Copy link
Member Author

koppor commented Dec 8, 2020

This issue is still relevant.

@Article{ALHashemy2020,
  author    = {Rageed Hussein AL{-}Hashemy and Sadiq A. Mehdi},
  journal   = {J. Intell. Syst.},
  title     = {A New Algorithm Based on Magic Square and a Novel Chaotic System for Image Encryption},
  year      = {2020},
  number    = {1},
  pages     = {1202--1215},
  volume    = {29},
  bibsource = {dblp computer science bibliography, https://dblp.org},
  biburl    = {https://dblp.org/rec/journals/jois/AL-HashemyM20.bib},
  doi       = {10.1515/jisys-2018-0404},
  file      = {:ALHashemy2020 - A New Algorithm Based on Magic Square and a Novel Chaotic System for Image Encryption (1).pdf:PDF},
}

Then

grafik

Then

@Article{ALHashemy2020,
  author    = {Rageed Hussein AL{-}Hashemy and Sadiq A. Mehdi},
  journal   = {J. Intell. Syst.},
  title     = {A New Algorithm Based on Magic Square and a Novel Chaotic System for Image Encryption},
  year      = {2020},
  number    = {1},
  pages     = {1202--1215},
  volume    = {29},
  bibsource = {dblp computer science bibliography, https://dblp.org},
  biburl    = {https://dblp.org/rec/journals/jois/AL-HashemyM20.bib},
  doi       = {10.1515/jisys-2018-0404},
  file      = {:ALHashemy2020 - A New Algorithm Based on Magic Square and a Novel Chaotic System for Image Encryption (2).pdf:PDF;:ALHashemy2020 - A New Algorithm Based on Magic Square and a Novel Chaotic System for Image Encryption (1).pdf:PDF},
}

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Dec 8, 2020
@JofielB
Copy link
Contributor

JofielB commented Dec 14, 2020

Hello, I would like to work on this issue

@cboyce376
Copy link

cboyce376 commented Mar 30, 2021

A group of us from Adelaide University are going to work on this issue over the next 4 weeks.

@Pikayue11
Copy link
Contributor

Hi, I think it has already been 4 weeks and I am interested in this issue. Could I try to fix it?

koppor pushed a commit that referenced this issue Sep 15, 2022
201e022 Update trends-journals.csl (#6224)
46e6eed Update nottingham-trent-university-library-harvard.csl (#6220)
684bb48 Update politix.csl (#6199)
c484b0b Update mcgill-fr.csl (#6198)
cbcf2f2 Update mary-ann-liebert-vancouver.csl (#6218)
47174f0 Create journal-of-dairy-research.csl (#6195)
fdd1eac Update harvard-anglia-ruskin-university.csl (#6196)
9e384d6 Create estonian-journal-of-earth-sciences.csl (#6194)
afba9b7 Delete moore-theological-college.csl as per university (#6197)
644549f Create acta-medica-philippina.csl (#6192)
6566114 Update rassegna-degli-archivi-di-stato.csl (#6186)
3509a2f Update universidade-federal-de-sergipe-departamento-de-engenharia-de-… (#6187)
de4845f Update mary-ann-liebert-vancouver.csl (#6213)
16828b6 Update ucl-university-college-apa.csl (#6172)
c08613b Update ucl-university-college-harvard.csl (#6173)
028bad4 Create sociologia-ruralis.csl (#6170)
77d428c Update journal-of-plankton-research.csl (#6169)
92e1022 Update and rename dependent/journal-of-the-national-cancer-institute.… (#6168)
120efb1 Update journal of hearing science
e503477 Create new-harts-rules-the-oxford-style-guide-author-date.csl (#6163)
49ab318 Create the-depositional-record.csl (#6159)
f4f6920 Update and rename laser-and-photonics-reviews.csl to dependent/laser-… (#6165)
d8ca4bc Update united-states-international-trade-commission.csl (#6162)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 201e022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external files good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants