Download of files put them in subfolders

[tobiasdiez]

Just a quick note for now: after downloading a linked online file, it was put in the folder standardRoot/citationkey/. Not sure why and under which conditions this is reproducible.

[Siedlerchr]

Did you specify a file fit name or file dir pattern?

[Siedlerchr]

I could reproduce it using some arxiv fulltext download from the General tab

[Siedlerchr]

The issue is here:

jabref/src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java

Line 451 in a080191

String fulltextDir = FileUtil.createDirNameFromPattern(databaseContext.getDatabase(), entry, filePreferences.getFileDirPattern());

If the parameter is empty string the citeky is returned.

jabref/src/main/java/org/jabref/logic/util/io/FileUtil.java

Lines 283 to 288 in 7cc5747

	public static String createDirNameFromPattern(BibDatabase database, BibEntry entry, String directoryNamePattern) {
	String targetName = BracketedPattern.expandBrackets(directoryNamePattern, ';', entry, database);
	if (targetName.isEmpty()) {
	targetName = entry.getCiteKeyOptional().orElse("default");
	}

[tobiasdiez]

@btut could you please have a look at this. If I'm not mistaken, then you added this in #6381. Thanks!

[btut]

Hi,
where was the file placed before my edits?
As far as I understand createDirNameFromPattern results in the citekey if no pattern is set. If this is not intended, I think it would be best to change that in createDirNameFromPattern. Is there any other place that method is used and the citekey being returned is the expected behaviour?

[Siedlerchr]

@btut I think the original method looked like a copy paste thing of the FileName Method.
So a fix would be to simply return empty string.
Would be nice if you could do this. And just add a test case to one of those CleanupRename methods

[Siedlerchr]

Now fixed in latest master

[btut]

Thanks!