Fix setting of title (and simplify BasePanel to LibraryTab) #6129

koppor · 2020-03-15T23:03:00Z

The code is not optimized for many opened tabs. The old code wasn't in too many places. We rely on title calculation of the current tab. It think, this is OK as the program title should reflect the tab title.

Current solution

Solution of `4b0b662` (OUTDATED)

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for bigger UI changes)
Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

tobiasdiez

Looks good to me, modulo some smaller suggestions.

tobiasdiez · 2020-03-16T14:18:02Z

src/main/java/org/jabref/gui/BasePanel.java

@@ -539,11 +507,12 @@ public void updateEntryEditorIfShowing() {
        }
    }

+    /**
+     * Put an asterisk behind the filename to indicate the database has changed.


Can you please investigate if this method is still really necessary. In principle, it should be enough to add listeners to the state manager to be notified about db changes. This would also fix the strange flow of information (from the base panel to the main frame).

I intensivly investigated this issue. I believe this method or something like it is still necessary until we can bind some property to an undomanager, which can provide a dirty flag for each library file.

src/main/java/org/jabref/gui/JabRefFrame.java

koppor · 2020-07-27T22:13:18Z

Some review comments cause much work on my side. Since I really like to have my two UI issues fixed, I intend to continue to work on this PR.

Note that we removed an easy indication whether the database is bibtex or biblatex. Since JabRef at some places communicates the mode to the user (e.g., different cleanup dialogs), I would spend time to think about the communication of that.

tobiasdiez · 2020-07-28T07:39:41Z

Note that we removed an easy indication whether the database is bibtex or biblatex. Since JabRef at some places communicates the mode to the user (e.g., different cleanup dialogs), I would spend time to think about the communication of that.

What about putting it in the tooltip? Something like

Library has changed. (depending on state)

Mode: BibLaTex
Path: C://....

Siedlerchr · 2020-08-31T15:11:36Z

How is the status here? Ready for merge?

koppor · 2020-09-02T00:17:12Z

The discussion regarding * refs #4161.

# Conflicts: # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/JabRefFrame.java

calixtus · 2020-10-18T13:35:03Z

I see some strange behaviour I don't understand and I'd like to ask for some help:
If I bind my list
EasyBind.bindContent(stateManager.getOpenTabs(), EasyBind.map(tabbedPane.getTabs(), tab -> ((LibraryTab) tab).getBibDatabaseContext)) the stateManager var openTabs stays empty. But if I bind EasyBind.bindContent(stateManager.getOpenTabs(), tabbedPane.getTabs()); it works. What am I doing wrong @tobiasdiez ?

tobiasdiez · 2020-10-18T14:03:11Z

It's probably again the problem that the listeners are only weak-references, so the mapped list is garbage-collected. You should be able to resolve this by keeping a class-reference of EasyBind.map(tabbedPane.getTabs(), tab -> ((LibraryTab) tab).getBibDatabaseContext), i.e. introduce a variable for it, and then use bindContent on this variable.

calixtus · 2020-10-18T15:31:19Z

You are right, that solved the issue. Thanks!

calixtus · 2020-10-19T20:51:59Z

My solution is now this:

modification-asterisk filename – path-fragment

The modification-asterisk (*) is shown if the file was modified since last save
(path-fragment is only shown if filename is not (globally) unique)

Example:
*jabref-authors.bib – testbib

The window title is bound to the tab title (just like notepad++), the bibtex mode is only displayed in the tooltip.
Comments? Suggestions? Damnations?

calixtus · 2020-10-19T21:08:27Z

calixtus · 2020-10-19T21:28:20Z

For your information: This PR escalated mainly because of this small comment.
#6129 (comment) 😉

tobiasdiez · 2020-10-20T10:58:54Z

Pffff... in der Beschränkung zeigt sich der Meister 😻

Not sure when I'll be able to review this PR, but after scrolling through it I really like it.

Siedlerchr · 2020-10-20T11:05:20Z

Wow! Huge work ;) I also think it's good
RIP variable BasePanel 😭

80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581) b6fb00e415 Create arachnologische-mitteilungen.csl (#6375) 2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580) fd230a7073 Create veterinary-clinical-pathology.csl (#6372) ac0afa3cae Create dedicated Basque APA file (#6370) fee0677a88 Update chicago-author-date.csl (#6289) ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230) f4116db325 Create Turcica.csl (#6240) 0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211) e73bf46674 Update vancouver.csl (#6156) b73c3ef193 Create independent TF AIP Style befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181) 048c9bddbc Add csl for SDMI (#6129) 1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567) b77084255f Update the-quarterly-journal-of-economics.csl (#6572) cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577) 9e9e08c219 Update isara-iso-690.csl (#6578) 4b4e8f442d Create silva-fennica.csl (#6568) dd8760bb2b Update american-journal-of-botany.csl (#6569) 8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560) 016050c4b7 Update geographie-et-cultures.csl (#6563) e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 80b3861bce121a64d43ef167581f8d100a4f70aa

…ce (#10048) 80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581) b6fb00e415 Create arachnologische-mitteilungen.csl (#6375) 2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580) fd230a7073 Create veterinary-clinical-pathology.csl (#6372) ac0afa3cae Create dedicated Basque APA file (#6370) fee0677a88 Update chicago-author-date.csl (#6289) ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230) f4116db325 Create Turcica.csl (#6240) 0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211) e73bf46674 Update vancouver.csl (#6156) b73c3ef193 Create independent TF AIP Style befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181) 048c9bddbc Add csl for SDMI (#6129) 1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567) b77084255f Update the-quarterly-journal-of-economics.csl (#6572) cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577) 9e9e08c219 Update isara-iso-690.csl (#6578) 4b4e8f442d Create silva-fennica.csl (#6568) dd8760bb2b Update american-journal-of-botany.csl (#6569) 8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560) 016050c4b7 Update geographie-et-cultures.csl (#6563) e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 80b3861bce121a64d43ef167581f8d100a4f70aa Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>

a97dbb32c5 Update studii-teologice.csl (#6591) e19e08780e Update acm-sig-proceedings-long-author-list.csl (#6594) c8abbcdd88 Update acm-sig-proceedings.csl (#6595) 725ace4a40 Create uppsala-university-library-harvard.csl (#6574) a973041e0e update bluebook-law-review.csl (#6583) 0891cfc49a Update masarykova-univerzita-pravnicka-fakulta.csl (#6589) 80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581) b6fb00e415 Create arachnologische-mitteilungen.csl (#6375) 2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580) fd230a7073 Create veterinary-clinical-pathology.csl (#6372) ac0afa3cae Create dedicated Basque APA file (#6370) fee0677a88 Update chicago-author-date.csl (#6289) ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230) f4116db325 Create Turcica.csl (#6240) 0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211) e73bf46674 Update vancouver.csl (#6156) b73c3ef193 Create independent TF AIP Style befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181) 048c9bddbc Add csl for SDMI (#6129) 1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567) b77084255f Update the-quarterly-journal-of-economics.csl (#6572) cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577) 9e9e08c219 Update isara-iso-690.csl (#6578) 4b4e8f442d Create silva-fennica.csl (#6568) dd8760bb2b Update american-journal-of-botany.csl (#6569) 8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560) 016050c4b7 Update geographie-et-cultures.csl (#6563) e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: a97dbb32c57c8c00e47422dae4ba4f480e753da5

0749a19b83 Update journal-of-experimental-botany.csl (#6604) b1768724fe Update modern-language-association.csl (#6606) dd364c1815 Create modern-language-association-for-JEI.csl (#6593) 6cb436997b Partial update of APA styles for 1.0.2, including software, legal, most localizations (#6270) d7c4ebec85 fix film/video authors for american-sociological-association.csl (#6602) a97dbb32c5 Update studii-teologice.csl (#6591) e19e08780e Update acm-sig-proceedings-long-author-list.csl (#6594) c8abbcdd88 Update acm-sig-proceedings.csl (#6595) 725ace4a40 Create uppsala-university-library-harvard.csl (#6574) a973041e0e update bluebook-law-review.csl (#6583) 0891cfc49a Update masarykova-univerzita-pravnicka-fakulta.csl (#6589) 80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581) b6fb00e415 Create arachnologische-mitteilungen.csl (#6375) 2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580) fd230a7073 Create veterinary-clinical-pathology.csl (#6372) ac0afa3cae Create dedicated Basque APA file (#6370) fee0677a88 Update chicago-author-date.csl (#6289) ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230) f4116db325 Create Turcica.csl (#6240) 0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211) e73bf46674 Update vancouver.csl (#6156) b73c3ef193 Create independent TF AIP Style befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181) 048c9bddbc Add csl for SDMI (#6129) 1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567) b77084255f Update the-quarterly-journal-of-economics.csl (#6572) cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577) 9e9e08c219 Update isara-iso-690.csl (#6578) 4b4e8f442d Create silva-fennica.csl (#6568) dd8760bb2b Update american-journal-of-botany.csl (#6569) 8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560) 016050c4b7 Update geographie-et-cultures.csl (#6563) e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 0749a19b8306f2e8dcb9bf1a2e3a6992666030ac

JabRef deleted a comment from codecov bot Mar 16, 2020

koppor force-pushed the fix-title branch from 4b0b662 to 4bbf398 Compare March 16, 2020 07:47

JabRef deleted a comment from codecov bot Mar 16, 2020

koppor force-pushed the fix-title branch from 4bbf398 to b29ff7e Compare March 16, 2020 07:59

koppor added 2 commits March 16, 2020 09:00

Fix setting of title (and remove obsolete comments)

f56e171

Tab titles is determined in JabRefFrame only

ffad7e8

koppor force-pushed the fix-title branch from b29ff7e to ffad7e8 Compare March 16, 2020 08:00

tobiasdiez requested changes Mar 16, 2020

View reviewed changes

JabRef deleted a comment from codecov bot Mar 16, 2020

koppor changed the title ~~Fix setting of title (and remove obsolete comments)~~ [WIP] Fix setting of title (and remove obsolete comments) Mar 21, 2020

tobiasdiez marked this pull request as draft April 17, 2020 16:00

koppor changed the title ~~[WIP] Fix setting of title (and remove obsolete comments)~~ Fix setting of title (and remove obsolete comments) Apr 23, 2020

koppor self-assigned this Apr 23, 2020

koppor mentioned this pull request May 29, 2020

Fix Unclear function of preference “Default bibliography mode” #6539

Closed

4 tasks

calixtus added 4 commits September 27, 2020 16:07

Merge remote-tracking branch 'upstream/master' into fix-title

97145ba

# Conflicts: # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/JabRefFrame.java

Fixed some small merge errors and code optimizations

ce0e098

Refactored BasePanel to LibraryTab and applied some IntelliJ suggestions

f3dacfc

Merge remote-tracking branch 'upstream/master' into fix-title-revisited

5ef16b9

koppor assigned calixtus and unassigned koppor Oct 13, 2020

calixtus added 4 commits October 13, 2020 08:14

Move title logic to LibraryTab

f923a48

Merge remote-tracking branch 'upstream/master' into fix-title-revisited

f302e73

Refactored property methods and removed unused code

ed3fc40

Removed BasePanelPreferences.java

9d78f28

Reenabled unique path parsing

0ab5e55

calixtus added 2 commits October 18, 2020 17:42

Changed getOpenTabs to getOpenDatabases in StateManager

1ad25fe

Fixed refresh of tab title on tab close and open

85fc785

calixtus changed the title ~~Fix setting of title (and remove obsolete comments)~~ Fix setting of title (and simplify BasePanel to LibraryTab) Oct 18, 2020

calixtus added 2 commits October 18, 2020 21:18

Fixed SaveDatabaseActionTest

067325d

Removed nameProperty and bound tab title to frame title

5324a9f

calixtus marked this pull request as ready for review October 19, 2020 20:52

calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui labels Oct 19, 2020

calixtus added 3 commits October 19, 2020 22:55

CHANGELOG.md

9c8b91b

Changed tooltip to display multiline texts

506e8de

Reordered display and added comments

45514a2

Merge branch 'master' into fix-title

d1257a2

koppor merged commit 4cf2fb0 into master Oct 20, 2020

koppor deleted the fix-title branch October 20, 2020 21:27

Siedlerchr mentioned this pull request Oct 30, 2020

Saving new library still shows "untitled*" in the tab bar #7053

Closed

calixtus mentioned this pull request Nov 13, 2020

Fixed setting title of saved new library #7095

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix setting of title (and simplify BasePanel to LibraryTab) #6129

Fix setting of title (and simplify BasePanel to LibraryTab) #6129

koppor commented Mar 15, 2020 •

edited by calixtus

Loading

tobiasdiez left a comment

tobiasdiez Mar 16, 2020

calixtus Oct 18, 2020

koppor commented Jul 27, 2020

tobiasdiez commented Jul 28, 2020

Siedlerchr commented Aug 31, 2020

koppor commented Sep 2, 2020

calixtus commented Oct 18, 2020

tobiasdiez commented Oct 18, 2020

calixtus commented Oct 18, 2020

calixtus commented Oct 19, 2020

calixtus commented Oct 19, 2020

calixtus commented Oct 19, 2020 •

edited

Loading

tobiasdiez commented Oct 20, 2020

Siedlerchr commented Oct 20, 2020

Fix setting of title (and simplify BasePanel to LibraryTab) #6129

Fix setting of title (and simplify BasePanel to LibraryTab) #6129

Conversation

koppor commented Mar 15, 2020 • edited by calixtus Loading

Current solution

Solution of 4b0b662 (OUTDATED)

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Mar 16, 2020

Choose a reason for hiding this comment

calixtus Oct 18, 2020

Choose a reason for hiding this comment

koppor commented Jul 27, 2020

tobiasdiez commented Jul 28, 2020

Siedlerchr commented Aug 31, 2020

koppor commented Sep 2, 2020

calixtus commented Oct 18, 2020

tobiasdiez commented Oct 18, 2020

calixtus commented Oct 18, 2020

calixtus commented Oct 19, 2020

calixtus commented Oct 19, 2020

calixtus commented Oct 19, 2020 • edited Loading

tobiasdiez commented Oct 20, 2020

Siedlerchr commented Oct 20, 2020

koppor commented Mar 15, 2020 •

edited by calixtus

Loading

Solution of `4b0b662` (OUTDATED)

calixtus commented Oct 19, 2020 •

edited

Loading