Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web icon also for ISBN #9819

Closed
koppor opened this issue Apr 30, 2023 · 2 comments · Fixed by #9925
Closed

Web icon also for ISBN #9819

koppor opened this issue Apr 30, 2023 · 2 comments · Fixed by #9925
Assignees
@shivamxsurya
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. maintable ui

Comments

@koppor
Copy link
Member

koppor commented Apr 30, 2023

I have the book 9783642643767 in my library. There is no icon for online resources for it:

image

(For entries with a DOI, there is one).

There should be a link icon for ISBNs too. The URL has to follow the pattern: https://openlibrary.org/isbn/{isbn}. Example: https://openlibrary.org/isbn/9783642643767.
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Apr 30, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Apr 30, 2023
@shivamxsurya
Copy link

since this is free to take , can i work on it.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Apr 30, 2023
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Apr 30, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Apr 30, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

mkumar09 added a commit to mkumar09/jabref that referenced this issue May 13, 2023
@mkumar09
Fix for JabRef#9819. Web icon also for ISBN
9ca396e
@mkumar09 mkumar09 mentioned this issue May 13, 2023
Closed
@ThiloteE ThiloteE moved this from Reserved to In Progress in Candidates for University Projects May 14, 2023
@ThiloteE ThiloteE moved this from In Progress to Under Review in Candidates for University Projects May 14, 2023
@mkumar09 mkumar09 mentioned this issue May 19, 2023
Merged
@github-project-automation github-project-automation bot moved this from Under Review to Done in Candidates for University Projects May 22, 2023
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivamxsurya shivamxsurya

Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. maintable ui
Projects
Candidates for University Projects
Archived in project
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Web Icon for ISBN mkumar09/jabref
Fixes Web icon also for ISBN mkumar09/jabref
3 participants
@koppor @shivamxsurya @ThiloteE