Fixes Web icon also for ISBN

[mkumar09]

Fixes #9819

Description : The ISBNs were not having a URL standard field in the BiBEntry fields. So made the changes to add the URL field in the BiBEntry retrieved from the fetcher.

Compulsory checks

Preview Give feedback

1. Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
2. Tests created for changes (if applicable)
3. Manually tested changed features in running JabRef (always required)
4. Screenshots added in PR description (for UI changes)
5. Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
6. Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[koppor]

Thank you for working on this. Please rethink the solution: JabRef knows the URL based on the precense of an ISBN. The link can be changed in future. Maybe one wants to open books on Amazon or the University Library. Then one does not want to change all bib files. If you opt for Amazon and I for university, the Bib file would change back and forth.

Thus, it is an UI issue. Check the main table how the URL is filled. I think, we have a field property ISBN, which can be used.

[koppor]

The implemention should work on the view not on the Bib data.

[calixtus]

You can take a look at BibEntryTableViewModel::createLinkedIdentifiersBinding .
I believe this would be a good starting point for a fix.

[mkumar09]

I checked BibEntryTableViewModel::createLinkedIdentifiersBinding.
@koppor @calixtus Does this fix work ?

private static EasyBinding<Map<Field, String>> createLinkedIdentifiersBinding(BibEntry entry) { return EasyBind.combine( entry.getFieldBinding(StandardField.URL), entry.getFieldBinding(StandardField.DOI), entry.getFieldBinding(StandardField.URI), entry.getFieldBinding(StandardField.EPRINT), entry.getFieldBinding(StandardField.ISBN), (url, doi, uri, eprint,isbn) -> { Map<Field, String> identifiers = new HashMap<>(); isbn.ifPresent(value -> identifiers.put(StandardField.URL,"https://openlibrary.org/isbn/"+value)); url.ifPresent(value -> identifiers.put(StandardField.URL, value)); doi.ifPresent(value -> identifiers.put(StandardField.DOI, value)); uri.ifPresent(value -> identifiers.put(StandardField.URI, value)); eprint.ifPresent(value -> identifiers.put(StandardField.EPRINT, value)); return identifiers; }); }

[koppor]

I can't see a diff. Would be good to do a commit. Then, one can also try out locally.

[koppor]

@mkumar09 Did you try your solution?

Two things to check:

A) does the web column display the icon if the ISBN is present?

B) Does a click on that icon open the page?

---

I think, your code snippet misses the first requirement.

[mkumar09]

@mkumar09 Did you try your solution?

Two things to check:

A) does the web column display the icon if the ISBN is present?

B) Does a click on that icon open the page?

I think, your code snippet misses the first requirement.

Hey @koppor. I checked the solution with this code snippet. It fulfills the first requirement,i.e, to show the link icon but for some reason, clicking on it doesn't open the page( on hovering over the link icon, it shows the correct URL but clicking doesn't work somehow)

[Siedlerchr]

Best is to push your code so we can have a chance to see all changes.