Exclude check for ampersand (&) at verbatim fields #10419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Sep 26, 2023
| @@ -24,6 +26,9 @@ public List<IntegrityMessage> check(BibEntry entry) { | |||
| List<IntegrityMessage> results = new ArrayList<>(); | |||
|
|
|||
| for (Map.Entry<Field, String> field : entry.getFieldMap().entrySet()) { | |||
There was a problem hiding this comment.
Maybe even cooler to integrate the filteirng directly in to the getFieldMap call?
e.g. entry.getFieldMap().entrySet().stream().filter...
https://mkyong.com/java8/java-8-filter-a-map-examples/
There was a problem hiding this comment.
I tried my best. Needed to use Tuple2 for the HtmlChecker. dc82d44
There was a problem hiding this comment.
I double checked that all usages do not modify the list any more
|
@systemoperator Your issue reported at #8712 (comment) should be fixed with this PR. |
Siedlerchr
previously approved these changes
Sep 26, 2023
Siedlerchr
reviewed
Sep 26, 2023
Siedlerchr
reviewed
Sep 26, 2023
Siedlerchr
previously approved these changes
Sep 26, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Sep 29, 2023
Siedlerchr
added a commit
that referenced
this pull request
Oct 3, 2023
* upstream/main: (94 commits) Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442) Update all of lucene Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0 Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0 Accept LaTeX errors in comment field (#10436) Fix NPEs in UrlCleanup (#10435) Fix triggering workflows (#10433) Show exception in cleanup error (#10430) Exclude check for ampersand (&) at verbatim fields (#10419) fix checkstyle fix escaping of slashes fix checkstyle and l10n Add TeXShop (macOS only) Fix casing First set fetcherWorker properties, then start the worker improve variable names checkstyle Fix fetcher worker execution on background thread Update contributing.md jakarta ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes koppor#585 (comment)
Refs #8712 (comment)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)