Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept LaTeX errors in comment field #10436

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Accept LaTeX errors in comment field #10436

merged 10 commits into from
Oct 2, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 1, 2023

This refs #8712 (comment) @systemoperator

In the comment, comment-{username}, and review fields, no HTML, LaTeX, or Ampersand-Check is done.

In the other fields, the commands mentioned at #8712 (comment) are now known.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 1, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 00c01a5 Oct 2, 2023
15 checks passed
@Siedlerchr Siedlerchr deleted the improve-latex-check branch October 2, 2023 14:23
Siedlerchr added a commit that referenced this pull request Oct 3, 2023
* upstream/main: (94 commits)
  Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442)
  Update all of lucene
  Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0
  Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0
  Accept LaTeX errors in comment field (#10436)
  Fix NPEs in UrlCleanup (#10435)
  Fix triggering workflows (#10433)
  Show exception in cleanup error (#10430)
  Exclude check for ampersand (&) at verbatim fields (#10419)
  fix checkstyle
  fix escaping of slashes
  fix checkstyle  and l10n
  Add TeXShop (macOS only)
  Fix casing
  First set fetcherWorker properties, then start the worker
  improve variable names
  checkstyle
  Fix fetcher worker execution on background thread
  Update contributing.md
  jakarta
  ...
Siedlerchr added a commit that referenced this pull request Oct 8, 2023
…in-protected-terms-files

* upstream/main:
  Update src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java
  Fix saving on network drive under macOS
  Infer DOI from ArXiv identifier (#10449)
  Add TexShop Icon (#10447)
  Fix PDF export (#10361)
  Fixed SpringerFetcherTest and ACMPortalFetcherTest (#10445)
  Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442)
  Update all of lucene
  Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0
  Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0
  Accept LaTeX errors in comment field (#10436)
  fix checkstyle
  fix escaping of slashes
  fix checkstyle  and l10n
  Add TeXShop (macOS only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants