Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open file in browser if is url #10480

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Open file in browser if is url #10480

merged 2 commits into from
Oct 12, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 11, 2023 •
edited
Loading

Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/152#issuecomment-1740419521

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Open file in browser if is url
6320b11 
Refs JabRef/jabref-issue-melting-pot#152 (comment)
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixBrowserOpening
7d7ed71 
* upstream/main:
  Add fields to CrossRef  (#10469)
  move changelog entry
  Close pop over early (#10477)
  This sets focus to new library (#10468)
  Polish AUX file import dialog (#10473)
  update gradle (#10471)

# Conflicts:
#	CHANGELOG.md
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 11, 2023
@Siedlerchr Siedlerchr requested a review from koppor October 11, 2023 17:18
@Siedlerchr Siedlerchr enabled auto-merge October 11, 2023 17:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit a97d8a9 Oct 12, 2023
14 checks passed
@Siedlerchr Siedlerchr deleted the fixBrowserOpening branch October 12, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @calixtus