Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed name column rendering #1499 and #1531 #1755

Merged
merged 2 commits into from
Aug 17, 2016
Merged

Fixed name column rendering #1499 and #1531 #1755

merged 2 commits into from
Aug 17, 2016

Conversation

oscargus
Copy link
Contributor

Fixed #1499 and #1531. Better to format the author names before converting LaTeX to Unicode... Bah!

capture17

- [x] Change in CHANGELOG.md described - [x] Tests created for changes - [x] Screenshots added (for bigger UI changes) - [x] Manually tested changed features in running JabRef - [x] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)

@oscargus oscargus added bug Confirmed bugs or reports that are very likely to be bugs ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Aug 16, 2016
@oscargus oscargus added this to the v3.6 milestone Aug 16, 2016
@@ -67,6 +67,9 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- Fixed NullPointerException when trying to set a special field or mark an entry through the menu without having an open database
- Fixed [#1257](https://github.com/JabRef/jabref/issues/1324): Preferences for the BibTeX key generator set in a version prior to 3.2 are now migrated automatically to the new version
- Fixed [#1716](https://github.com/JabRef/jabref/issues/1716): `@`-Symbols stored in BibTeX fields no longer break the database
- Fixed [#1499](https://github.com/JabRef/jabref/issues/1499): {} braces are now treated correctly in in author/editor
- Fixed [#1531](https://github.com/JabRef/jabref/issues/1531): \relax can be used for abbreviation of author names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the \relax in the code-quotes, but that is just a small unrelated thing..;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that is both related and relevant. ;-)

I'll fix it tomorrow (later today).

Den 17 aug. 2016 00:08 skrev "Christoph" notifications@github.com:

In CHANGELOG.md
#1755 (comment):

@@ -67,6 +67,9 @@ We refer to GitHub issues by using `#

  • Fixed NullPointerException when trying to set a special field or mark an entry through the menu without having an open database
  • Fixed #1257: Preferences for the BibTeX key generator set in a version prior to 3.2 are now migrated automatically to the new version
  • Fixed #1716: @-Symbols stored in BibTeX fields no longer break the database
    +- Fixed #1499: {} braces are now treated correctly in in author/editor
    +- Fixed #1531: \relax can be used for abbreviation of author names

I would put the \relax in the code-quotes, but that is just a small
unrelated thing..;)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JabRef/jabref/pull/1755/files/752c54d5d96fbfd2861970a8fb86463f0ac1ad86#r75030057,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHvRQedYCQBoTKdLOEle7MnEtbznpt5cks5qgjTZgaJpZM4Jl1UE
.

@Siedlerchr
Copy link
Member

Good work, simple change for fixing two issues at the same time, LGTM 👍


@Test
public void testCompanyAuthor() {
Author author = AuthorList.parse("{JabRef Developers}").getAuthor(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer tests in the form

Author expected = new Author("Firstname", "F.", null, "Bailey-Jones", null);
Assert.assertEquals(new AuthorList(expected), AuthorList.parse("Firstname Bailey-Jones"));

They are shorter and provide better feedback what went wrong parsing the author (instead of getFirst was something but expected null, you get a complete diff of all information in the parsed author vs expected author).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez
Copy link
Member

LGTM 👍
Please slightly rewrite the tests and then you can merge it.

@oscargus oscargus merged commit 6701a9e into master Aug 17, 2016
@oscargus oscargus deleted the fix1499 branch August 17, 2016 07:20
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants