-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed name column rendering #1499 and #1531 #1755
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -375,6 +375,37 @@ public void testGetAuthor() { | |
Assert.assertEquals("von Neumann", author.getLastOnly()); | ||
Assert.assertEquals("Neumann, Jr, J.", author.getNameForAlphabetization()); | ||
Assert.assertEquals("von", author.getVon()); | ||
|
||
} | ||
|
||
@Test | ||
public void testCompanyAuthor() { | ||
Author author = AuthorList.parse("{JabRef Developers}").getAuthor(0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer tests in the form
They are shorter and provide better feedback what went wrong parsing the author (instead of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense. Just copied the earlier ones now.
|
||
Assert.assertNull(author.getFirst()); | ||
Assert.assertNull(author.getFirstAbbr()); | ||
Assert.assertEquals("JabRef Developers", author.getLast()); | ||
Assert.assertNull(author.getJr()); | ||
Assert.assertNull(author.getVon()); | ||
} | ||
|
||
@Test | ||
public void testCompanyAuthorWithLowerCaseWord() { | ||
Author author = AuthorList.parse("{JabRef Developers on Fire}").getAuthor(0); | ||
Assert.assertNull(author.getFirst()); | ||
Assert.assertNull(author.getFirstAbbr()); | ||
Assert.assertEquals("JabRef Developers on Fire", author.getLast()); | ||
Assert.assertNull(author.getJr()); | ||
Assert.assertNull(author.getVon()); | ||
} | ||
|
||
@Test | ||
public void testAbbreviationWithRelax() { | ||
Author author = AuthorList.parse("{\\relax Ch}ristoph Cholera").getAuthor(0); | ||
Assert.assertEquals("{\\relax Ch}ristoph", author.getFirst()); | ||
Assert.assertEquals("{\\relax Ch}.", author.getFirstAbbr()); | ||
Assert.assertEquals("Cholera", author.getLast()); | ||
Assert.assertNull(author.getJr()); | ||
Assert.assertNull(author.getVon()); | ||
} | ||
|
||
@Test | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the \relax in the code-quotes, but that is just a small unrelated thing..;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that is both related and relevant. ;-)
I'll fix it tomorrow (later today).
Den 17 aug. 2016 00:08 skrev "Christoph" notifications@github.com: