Removed one Globals call from MetaData #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
status: ready-for-review
oscargus
changed the title
| @@ -51,4 +56,9 @@ public boolean isEnforceLegalKey() { | |||
| } | |||
|
|
|||
| public String getDefaultBibtexKeyPattern() { return defaultBibtexKeyPattern;} | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Duplicate empty line. @koppor is this caused by our Eclipse Settings? I'm seeing that all the time.
There was a problem hiding this comment.
This one is probably my bad, although I know sometimes Eclipse add double empty lines.
|
Minor Comments otherwise LGTM 👍 |
3 tasks
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 24, 2016
* master: Some more Swedish translations (JabRef#1836) Updated Menu_tr.properties Updated jabref_tr.properties Add check for obsolete database structure. Add help popup. (JabRef#1818) Updated dependencies (JabRef#1831) Removed one Globals call from MetaData (JabRef#1782)
Siedlerchr
added a commit
that referenced
this pull request
Aug 24, 2016
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One further step towards a
Globals-freeMetaData.