Support \r when using CitationStyles #2165
Conversation
boceckts
added
status: ready-for-review
| @@ -56,17 +56,18 @@ protected static String generateCitation(BibEntry entry, String style, CitationS | |||
|
|
|||
| } catch (IOException | ArrayIndexOutOfBoundsException e) { | |||
| LOGGER.error("Could not generate BibEntry Citation", e); | |||
| return Localization.lang("Cannot generate Citation"); | |||
There was a problem hiding this comment.
I think, this generates the string displayed in the preview panel. Maybe, the message should be "Cannot generate preview based on selected citation style".
Further, "Citation" is not a fixed term, which should be uppercased. Put it lower case as most English words are lower case.
|
Have you filed an upstream issue? You know, including minimal example. Similar to @obraliar did it for pgjdb-ng (https://github.com/obraliar/pgjdbc-ng-test#pgjdbc-ng-casing-test). Maybe you also dived into the CSL library and could propose a fix for the lib (PR at their repo) |
|
Is it possible to add a test case based on the example of JabRef#174. Further, a test case covering the exception branch should be made. Maybe using an invalid latex sequene in the entry helps to generate the exception? Besides these minor comments: LGTM. |
|
Sadly I cannot reproduce another case where the I created an issue in the repository of the library: michel-kraemer/citeproc-java#30. |
|
OK for me. - Either we keep this fix or include |
|
If I got this right, just use the SNAPSHOT version for now. Is a more long term solution using the fixed version instead of monkey-patching it? |
koppor
removed
the
status: ready-for-review
|
Used the Snapshot which gets rid of the Rhino dependency as well. |
koppor
changed the title
Fixes: JabRef#174
The CitationStyle library cannot handle
\rthus I parse to aspace.I also added another return (and localization) to always have a feedback for the user.