Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups button and context menu for adding groups #2508

Merged
merged 5 commits into from
Feb 2, 2017
Merged

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 1, 2017

Add a button (and context menu) for adding groups in the new interface. Some todo's are still open, because they are easier to implement as soon as the majority of the group stuff is converted to javafx.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 1, 2017
@lenhard
Copy link
Member

lenhard commented Feb 2, 2017

I played around a little with the UI interface. The tree and the context menu are fine I think. However (not using groups that much), it took me quite some time to locate the button you talked about.

The button was located at the bottom of the interface also in the old groups interface, right? I think the rewrite of the groups panel gives us an opportunity to try to improve a few things. Personally, I think it would be better if the button were moved to the top, right under the heading of the groups sidepane and above the "All Entries" group. What do you think?

Also, support for assigning entries to groups by drag and drop would be cool :-)

@tobiasdiez
Copy link
Member Author

You are of course right; we should use the rewrite to improve the interface. Thats why I moved the "new group" button from the top to the bottom 😄. My reasoning was that in the majority of the cases you are interested in selecting a group in order to find a assigned entry. Once you have an established group tree, the "new group" functionality is used very rarely. Thus the groups tree is way more important than the add button and should thus be put more prominently, i.e., at the very top. On the other hand, I can see that the add button at the bottom looks a bit disconnected from the groups tree (especially if you have only a few groups). Not sure how to improve this through.

But in the end, I have not a very strong opinion about the location of the button and it is very easy to change. My proposal would be to leave the button at the bottom for the moment and revisit this question as soon as more buttons/functionality is added to the groups pane.

@lenhard
Copy link
Member

lenhard commented Feb 2, 2017

I don't have a strong opinion either :-) @JabRef/developers What does the rest of you think?

@Siedlerchr
Copy link
Member

It would be nice if you could provide a screenshot. Otherwise I don't really care where it it as long as it is there. This is what I wanted in #2467

@tobiasdiez tobiasdiez merged commit 6bd8f4c into master Feb 2, 2017
@tobiasdiez tobiasdiez deleted the groupsAdd branch February 2, 2017 19:34
Siedlerchr added a commit that referenced this pull request Feb 3, 2017
* upstream/master:
  Fix export of number + pubstate in OFFice XML (#2514)
  Groups button and context menu for adding groups (#2508)
  Fix journal title in ris importer (#2510)
  French localization: Main file: translations of strings (#2512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants