Fix journal title in ris importer #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschechlovdev
changed the title
tschechlovdev
added
the
status: ready-for-review
lenhard
reviewed
Feb 2, 2017
| @@ -129,7 +129,11 @@ public ParserResult importDatabase(BufferedReader reader) throws IOException { | |||
| fields.put(FieldName.TITLE, fields.get(FieldName.TITLE).replaceAll("\\s+", " ")); // Normalize whitespaces | |||
| } else if ("BT".equals(tag)) { | |||
| fields.put(FieldName.BOOKTITLE, value); | |||
| } else if ("T2".equals(tag) || "JO".equals(tag)) { | |||
| } else if ("T2".equals(tag)&&(fields.get(FieldName.JOURNAL) == null || "".equals(fields.get(FieldName.JOURNAL)))){ | |||
There was a problem hiding this comment.
Could you fix the formatting in the condition here? I am referring to whitespaces between operators && and the operands.
There was a problem hiding this comment.
Done. Also added a changelog entry.
tobiasdiez
removed
the
status: ready-for-review
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2506.
The problem was that the T2 field was used for the journal title, if it comes first. Now T2 is only used for the journal title, if the field JO does not appear. I've also added the file from science direct as test case.