Add Remove link context menu entry in file editor #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
tobiasdiez
approved these changes
Jul 5, 2017
There was a problem hiding this comment.
The changes in this PR look good to me, but please don't forget #2939 (comment) which in light of these changes is even more significant.
tobiasdiez
reviewed
Jul 5, 2017
| @@ -146,11 +146,15 @@ private ContextMenu createContextMenuForFile(LinkedFileViewModel linkedFile) { | |||
| deleteFile.setOnAction(event -> viewModel.deleteFile(linkedFile)); | |||
| deleteFile.setDisable(linkedFile.getFile().isOnlineLink()); | |||
|
|
|||
| MenuItem deleteLink = new MenuItem(Localization.lang("Remove link")); | |||
| deleteLink.setOnAction(event -> viewModel.removeFileLink(linkedFile)); | |||
| deleteLink.setDisable(linkedFile.getFile().isOnlineLink()); | |||
There was a problem hiding this comment.
I think it also makes sense to enable it for online links.
Siedlerchr
added a commit
that referenced
this pull request
Jul 11, 2017
* upstream/master: Eclipse J Add switch indentation for Eclipse and add some new missing formatting options Check for different editions in the duplicate check (#2991) Add CheckStyle Check for Constants (final static) (#2992) Add Remove link context menu entry in file editor (#2972) Fix DiVA tests Remove <pre> tag from entries fetched using MathSciNet (#2990) Fix Brazilian Portugese language loading (#2981) Use sftp's symlink command to provide symlink to latest version Update gradle from 4.0 to 4.0.1 Fix group storage (#2978) Fix keybindings in entry editor (#2971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2968
gradle localizationUpdate?