Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brazilian Portugese language loading #2981

Merged
merged 2 commits into from
Jul 9, 2017
Merged

Fix Brazilian Portugese language loading #2981

merged 2 commits into from
Jul 9, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 7, 2017

Fix regression bug #1182
Pass language and country as separate args for Locale constructor

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Fix regression bug #1182
Pass language and country as separate args for Locale constructor
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 7, 2017
@Siedlerchr Siedlerchr requested a review from koppor July 7, 2017 22:37
@koppor koppor merged commit 220d654 into master Jul 9, 2017
@koppor koppor deleted the fixptBrlang branch July 9, 2017 11:51
Siedlerchr added a commit that referenced this pull request Jul 10, 2017
* upstream/master:
  Fix Brazilian Portugese language loading (#2981)
  Use sftp's symlink command to provide symlink to latest version
  Update gradle from 4.0 to 4.0.1
  Fix group storage (#2978)
  Fix keybindings in entry editor (#2971)
Siedlerchr added a commit that referenced this pull request Jul 11, 2017
* upstream/master:
  Eclipse J
  Add switch indentation for Eclipse and add some new missing formatting options
  Check for different editions in the duplicate check (#2991)
  Add CheckStyle Check for Constants (final static) (#2992)
  Add Remove link context menu entry in file editor (#2972)
  Fix DiVA tests
  Remove <pre> tag from entries fetched using MathSciNet (#2990)
  Fix Brazilian Portugese language loading (#2981)
  Use sftp's symlink command to provide symlink to latest version
  Update gradle from 4.0 to 4.0.1
  Fix group storage (#2978)
  Fix keybindings in entry editor (#2971)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants