Fix for issue 2811: bibtexkey generator does not use crossref information #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125m125
changed the title
Siedlerchr
approved these changes
Oct 2, 2017
| String bibtexString = "@ARTICLE{entry2, author={Mari D. Herland and Mona-Iren Hauge and Ingeborg M. Helgeland}}"; | ||
| BibEntry entry2 = BibtexParser.singleFromString(bibtexString, importFormatPreferences).get(); | ||
| database.insertEntry(entry2); | ||
| System.out.println(entry1.getResolvedFieldOrAlias(FieldName.AUTHOR, database)); |
There was a problem hiding this comment.
Seems like you have forgotten to remove the system out print here
tobiasdiez
requested changes
Oct 3, 2017
| BibEntry entry1 = new BibEntry(); | ||
| entry1.setField(FieldName.CROSSREF, "entry2"); | ||
| database.insertEntry(entry1); | ||
| String bibtexString = "@ARTICLE{entry2, author={Simon Holland}}"; |
There was a problem hiding this comment.
Please construct the entry by hand (as you did for entry1) instead of using the parser. I know, the other tests also work like that but this is bad design.
|
@125m125 That is really an impressive amount of tests, good job! There are two merge conflicts. Could you resolve those? Once that's done this PR is ready to go into master. |
|
And once again thanks! |
Siedlerchr
added a commit
that referenced
this pull request
Oct 7, 2017
* upstream/master: (113 commits) Open statistics dialog from correct thread (#3272) Fix for issue 2811: bibtexkey generator does not use crossref information (#3248) Fix for issue 3143: Import entry from clipboard in different formats (#3243) French translation correction (#3262) Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate (#3266) Directory pattern bracketed expressions (#3238) Show development information Release v4.0 add another author to mailmap moved changelog entry to the right category update new AUTHORS info Update log4j from 2.9.0 -> 2.9.1 fix dblp fetcher Add missing Turkish translation Add "-console" parameter for Windows launcher (#3242) Path check converted to if statement Changelog updated Fixed renaming files which are not in main directory. Only use last name for auto completion in search bar. Fixes koppor#253 Implemented issue #3229 (#3233) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2811
The BibTex key generator now uses crossreferenced entries if required fields are empty.