Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate #3266

Merged

Conversation

125m125
Copy link
Contributor

@125m125 125m125 commented Oct 5, 2017

see #2955 (comment)
To wait before showing the TrackingNotification, a new ScheduledExecutorService was created but never shutdown. Now the daemon Timer of the JabRefExecutorService is used.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@125m125 125m125 changed the title Ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate Oct 5, 2017
@tobiasdiez tobiasdiez merged commit 7ef2b3a into JabRef:master Oct 6, 2017
@tobiasdiez
Copy link
Member

Thanks for the quick fix! Since it is only a small code change, I take the liberty to merge it directly.

Siedlerchr added a commit that referenced this pull request Oct 7, 2017
* upstream/master: (113 commits)
  Open statistics dialog from correct thread (#3272)
  Fix for issue 2811: bibtexkey generator does not use crossref information (#3248)
  Fix for issue 3143: Import entry from clipboard in different formats (#3243)
  French translation correction (#3262)
  Wait to ask to collect anonymous statistics in JabRefExecutorService to allow jvm to terminate (#3266)
  Directory pattern bracketed expressions (#3238)
  Show development information
  Release v4.0
  add another author to mailmap
  moved changelog entry to the right category
  update new AUTHORS info
  Update log4j from 2.9.0 -> 2.9.1
  fix dblp fetcher
  Add missing Turkish translation
  Add "-console" parameter for Windows launcher (#3242)
  Path check converted to if statement
  Changelog updated
  Fixed renaming files which are not in main directory.
  Only use last name for auto completion in search bar. Fixes JabRef#253
  Implemented issue #3229 (#3233)
  ...
@koppor
Copy link
Member

koppor commented Oct 26, 2017

@125m125 - Did you sign up for https://hacktoberfestchecker.herokuapp.com/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants