[WIP] Main table JavaFX migration #3621

…ble-beta

…lEverything

* Fix padding issues and restyle text input controls * Improve look of scrollbars

TODO: ExternalfileType and Content Selectors do not work/throw an NPE

…bref into javafxGlobalEverything

…avafxGlobalEverything * upstream/javafxGlobalEverything: Remove unused code Fix a few NPEs Add push to external application menu entry # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java

Fix File Annoation tab exception due to FileUpdateMonitor Fix NPE when entry has files but no URL, DOI or etc field Fix open forum link to http, https does not work Log errors in DocumentViewer to logger and not sys.err

* Add the Menubar to the Titlebar in MacOS * Remove obsolete Swing menubar stuff

…o javafxGlobalEverything

Make JavaFX a first-class citizen

First test looked okay now

try to hunt down exception on linux with fileupdate monitor

revert debug output

…nitor

* Use library for drag'n'drop support for tabs * Use DnDTab library

* Track telemetry of each action * Set main stage for file dialogs

* Fix delete action and convert confirmation dialog to JavaFX * Named buttons in delete confirmation dialog

* Add more buttons to the toolbar * Reenable tool tips for toolbar buttons * Add undo/redo buttons * Do not bind rightSide width * Description as tooltip

* Change open last edited dialgo to javafx * Rename variable Add missing localization keys

The setting of the tooltip led to an exception. It is already implicit set from the Action Description

I think it would be nice to have travis build for maintable-beta. That would show us some potential errornous tests or

) * Prototype * Make transparent * Remove everything related to marked entries * Display proper group membership for entry * Add migration from markings to groups

* convert dialogs to javafx start with preferences * convert open office and other preferences * Convert entryTypeList and entry customization and shared database * And convert some more * Pass dialogService instead of frame convert some more dialogs Fix index out of bounds in Entry Table columns Pref Tab * entry types list * create choice dialog * ADd method for returning list in Encodings Display charsets in Choices dialog * Convert some more confirmation dialogs * convert some more dialogs Extend choice dialog with cancel button and ok button label * fix checkstyle and add missing lang keys * fix dialog conditions * add better title for share db dialog * Add dialogservice to push to apps Remove comment form import insepction dlg * add new keys * fix dialog service in push * checkstyle and convert some open office dlgs, too * use dialogservice as local variable Fix l10n keys * pass Dialog service to push dialogs as ctor arg * checkstyle

Main drawback: Cleanup panel is in backgroung due to swing thread)

convert merge entries dlg to javafx and make action working again

…s dlg

Wrap error messages in fx executor (because abstract worker is swing thread)

)

* Get rid of customjfx hack Big step towards jdk9 compatibility No longer needed CodeArea still does not work * Remove TextArea and rework Edit Preamble Dialog to javafx to be on the safe side with customjfxpanel * Remove basePanel from Preamble Change * fix non in fx thread issue

Follow up from #3818 # Conflicts: # src/main/java/org/jabref/gui/actions/CopyFilesAction.java # src/main/resources/l10n/JabRef_en.properties

…ble-beta

Convert last dialog to javafx refactor exception

* Add new Eclipse style to align on column Exported from Oxygen.2 * add doc on how to update eclipse style files * Fix typos * Update doc

Pressing ESC while searching clears searchfield and selects first available entry

…ble-beta

add missing keybinding of search

* Watch main css file for change and reapply automatically * Code cleanup * Code cleanup, this time right * Hide thrown exception * Don't monitor css files bundled in jar * Add java property to make location of Main.css customizable The "live reloading" has now to be turned on by defining -Djabref.main.css Additionally, the location of the Main.css file can be given as parameter to this property. This makes it way more convenient when working on the code, because usually the location of the Main.css is in the build folder. Now, you can use the Main.css from the source directly. * rename constants to correct format Co-authored-by: Tobias Diez <tobiasdiez@gmx.de> Co-authored-by: Patrick Scheibe <patrick@halirutan.de>

* upstream/master: Provides download option in context menu and fixes #3614 (#3824) Minor refactoring # Conflicts: # src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java # src/test/java/org/jabref/architecture/TestArchitectureTests.java # src/test/java/org/jabref/gui/fieldeditors/LinkedFileViewModelTest.java

…where necessary

except L10n

* Extract swing dialog display to dialog service * Embed preference dialog in JavaFX window * Use new version of afterburner * Fix injection into controller classes * Fix build and code cleanup

Bunch of smaller improvements

…ble-beta

State button

* javafx replacement for file dialog * Add some core structure for selectFilesDialog * Add Properties for binding * add getters * Renaming, use properties in controller open dialog with attach file action * port some more code * Asssign combobox selected value property * fix some formatting * make getController public to get viewModel * add enum with config values instead of booleans * Fix depdendency injection * Rework * Merge remote-tracking branch 'upstream/master' into maintable-beta * upstream/master: Provides download option in context menu and fixes #3614 (#3824) Minor refactoring # Conflicts: # src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java # src/test/java/org/jabref/architecture/TestArchitectureTests.java # src/test/java/org/jabref/gui/fieldeditors/LinkedFileViewModelTest.java * Create Wrapper to pass LinkedFile around TODO: what do to on edit? How to save the new file? * fix some indentations update File after Edit * remove open unknown external file type dialog convert ImportInspectionDialog to use new file edit dialog * fix indentation * convert attachFileDialog to javafx show file open dialog on attach file show dialog for editing file afterwards * reformat * Mark old filelist as deprecated Pass Preferences Service instead of Preferences * fix checkstyle remove unused parameter entry * fix checkstyle again * add changelog Move fxml to resources rework layout to grid * adjust indentation * convert to new FXML dialog model funcionality still some NPEs * fix empty lines * fix checkstyle * Fix viewModel NPE in copyFiles Action and linkedfilesEditDialog * Add close button in copy linked files * fix checkstyle * Rename and reformat * remove changelog move fxml to java package remove wrapper class pass externalFileType to viewModel renammings * remove close method Add ok button to dialog pane * change some odd looking assigments * renaming * forgotten rename

* Separate colors * More consistent layout * Remove many explicit color settings and make the style dependent on a few base colors * Remove color gradients for controls * Add custom application icons in the same style as existing MaterialDesignIcon * Fix transparent cell borders for main-table * Change some icons for consistent visual weight and additional adaptions In the main toolbar, I changed the "New File" icon because it was an outlined version while Open and Save is a filled version. For the Open icon I would like to have the "folder-open", but that is currently not included in our version. I changed the Add Entry icon to a filled version as well, since it better fits the trash. Unfortunately, there is no filled version of Copy and Paste and the positively filled version of GitHub looks just awful. I changed the Up, Down, and Close icon for the sidepanel and the entry editor to versions that look visually more similar in size. Especially, the up and down was too small. After correspondence with a friend, I changed the default list item before the groups into something not so heavy. The small triangle with its vertical side on the left gives additionally a better impression of the indentation which is the key here. The Add Group icon was changed into a heavier circled version. It now matches the style of the close button of the sidepanel and entry editor. All icons of "sub toolbars" in the entry editor and the side panel have now an equal size of 16px. The preferred height of the side-panel header and the header of the tab-pane was adjusted so that they match and there is no jump between main-table and side-panel anymore. There might be a better way to do this. Finally, the color of the overflow buttons for toolbar and tab-pane was adjusted. * Reduce the brightness of highlighted menu, marked text, etc Slightly reducing this color still looks very nice and it gives a better impression when text is marked. * Fix icon sizes of the custom TTF * Fix OO and Emacs icon. Additionally, an alternative version for Vim was added and slight improvements on other icons. * Fix size of Copy and Paste icon to original one. * Fix several style issues as reaction to the comments of the PR

Base.css: - Introduce explicit colors for hover/select of table. This needs to be adjust for dark theme (-jr-hover-color, -jr-select-color) - Additional color for hovered menu text. No influence on light theme but might be needed in the dark theme -jr-menu-foreground-active - A slightly darker gray for main text - reenabled hover effect for icons - reenabled theme color for tab labels. If required for dark theme lets introduce a separate color for it - fixed tab close button - in light theme we need a visible border for the split pane. Otherwise e.g. main table and preview have no visible border. - removed that a selected entry in table has a different color when the maintable is not focused. - fixed hover highlighting for menu GroupTree.css - the bottom border is not required, but with the search bar in white, we need a visible border to the group tree itself ErrorConsole.css - fixed the style EntryEditor.css - Same color for code area then the rest Entry Editor code area uses the same font color as the rest of the

- Make separator in groups panel the same as in entry editor and main table - Replace shadow effect on hover by button-like outline - Sightly darker selected and hovered colors - Color toolbar and menu - Make focus outline of text fields consistent

…or-annotations # Conflicts: # src/test/java/org/jabref/gui/importer/fetcher/OAI2HandlerFetcherTest.java

Remove all @author comments and empty method/class comments

Buttons now have a simply hover effect as suggested by Tobi. To make this work consistently, I *did not* use a color for the effect. Instead, simple black (or white for the dark-scheme) is used with a high value of alpha. This works independent of the underlying background by just darkening the area a bit. I removed the second hover color and replaced it by alpha darkening as well. Other small fixes include the toolbar context menu and adjustments to group view and entry editor. Finally, I tried to bring the changes to the dark version.

Remove unused code in cleanup No need to set swing content on swing thread

* Refactor RegEx Formatter * Fix formatting * Reorder return statements in `getFormatterForModifier` * Fix order in RegexFormatter

- Slightly increase size of menu (touch-friendlier) - Make sidebar slightly darker - Color icons as text in the same place would be colored

Dark theme

…ble-beta

* upstream/master: Pdf exporter - delete xmp actions in the menu bar and the cli option (#3947) Improve search performance (#3950) New Crowdin translations (#3949) Update dependencies for junit, mockito and checkstyle (#3951) Add XMP Exporter (#3895) Switch colors of search icon for the two search modes (#3871) # Conflicts: # src/main/java/org/jabref/gui/search/GlobalSearchBar.java

* upstream/master: (47 commits) Fix xmp exporter (#3964) Update JUnit from 5.2.0-M1 -> 5.2.0-RC1 Update xmlunit from 2.5.1 -> 2.6.0 Update mockito-core from 2.18.0 -> 2.18.3 Fixieee (#3970) Fix IEEE Fetcher by enabling cookie support (#3968) Update flowless from 0.6 -> 0.6.1 Update wiremock from 2.16.0 -> 2.17.0 Fix ebook.de (#3967) LOC test #3854 Fix arxiv tests New translations JabRef_en.properties (French) (#3963) Upgrade modernizer plugin New Crowdin translations (#3962) Fix test Improve test New Crowdin translations (#3961) New translations JabRef_en.properties (French) (#3960) Remove brackets before checking equality Replace all IEEE URLs with https #3930 (#3944) ... # Conflicts: # build.gradle # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/collab/ChangeScanner.java # src/main/java/org/jabref/gui/exporter/ExportAction.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java # src/main/java/org/jabref/gui/openoffice/DetectOpenOfficeInstallation.java # src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java # src/main/java/org/jabref/gui/preftabs/PreferencesDialog.java

add BitexKeyPattern prefs to entry editor

* Refactor external file types and extract interface * Fix ExternalFileType dialog * Catch exception for not valid paths * Fix build * Fix checkstyle

…ble-beta

* Fix IEEE preview does not display month (#3239) On month change from comboBox on OptionalFieldsTab: 1. Month was not appear on IEEE style. 2. Month was not written correctly on SourceTab. both issues get fixed. * Fix IEEE preview does not display month (#3239) #3983 (comment) * Fix IEEE preview does not display month (#3239) #3983 (comment) * Fix IEEE preview does not display month (#3239) Wrong order for 'org.jabref.model.entry.FieldName' import. * Fix IEEE preview does not display month (#3239) fix missing check style issue * Fix IEEE preview does not display month (#3239) Remove Superfluous Comments #3983 (comment) * Fix IEEE preview does not display month (#3239) Make change direct on bibTeXEntry instead of creating a copy of bibEntry * Fix IEEE preview does not display month (#3239) fix check style issue * Fix IEEE preview does not display month (#3239) #3983 (comment)

* upstream/master: New translations JabRef_en.properties (French) (#4009) Fix Look and Feel related issues (#4002) Fix statement in changelog [WIP] Add Text File Export for "Find Unlinked Files" (#3979) # Conflicts: # src/main/java/org/jabref/JabRefGUI.java # src/main/java/org/jabref/gui/preftabs/AppearancePrefsTab.java # src/main/java/org/jabref/migrations/PreferencesMigrations.java

* Add button for union/intersection in the groups side panel Fix display ofs state in preferences * add method for getting addtionalHeaderButtons create enum with icons change booleans to enum remove duplicated code remove old prefs * remove uncommented code * fix checkstyle * Add group intersection and union icons * add tooltips for side pane and groups pane * Extract get graphics and tooltip to new class return headerbuttons as list * refactor and extract icon method to view model make prefs private

* Reimplement tooltips for file and identifier column * Extract not translatable strings out of localization

* upstream/master: Fix ACM fetcher import of entries (#4019) Update Dependencies (#4012)

…ble-beta

…own all running threads

* Remove usage of transitive dependency on Apache Commons (cherry picked from commit 6608b2b) * Use JavaFX-native SVGPath for logo in About dialog

* Switch to org.postgresql * fix checkstyle fix driver setup connection * convert error message dialog to dialog service

* upstream/master: update gradle to 4.7 (#4049) Add missing translation for "HTML to Unicode" (#4046) New Crowdin translations (#4042) Use all-text-fields magic also in BibTeX cleanup. (#4039) Shortittle bibtexkeypattern now also discards small words (#4030)

# Conflicts: # CHANGELOG.md # build.gradle # src/main/java/org/jabref/JabRefGUI.java # src/main/java/org/jabref/JabRefMain.java # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/EntryTypeDialog.java # src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/actions/CopyFilesAction.java # src/main/java/org/jabref/gui/collab/ChangeScanner.java # src/main/java/org/jabref/gui/entryeditor/EntryEditor.css # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/entryeditor/SourceTab.java # src/main/java/org/jabref/gui/exporter/ExportAction.java # src/main/java/org/jabref/gui/exporter/ExportToClipboardAction.java # src/main/java/org/jabref/gui/externalfiles/DownloadExternalFile.java # src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java # src/main/java/org/jabref/gui/externalfiles/SynchronizeFileField.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java # src/main/java/org/jabref/gui/openoffice/DetectOpenOfficeInstallation.java # src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java # src/main/java/org/jabref/gui/preftabs/AppearancePrefsTab.java # src/main/java/org/jabref/gui/preftabs/PreferencesDialog.java # src/main/java/org/jabref/gui/search/GlobalSearchBar.java # src/main/java/org/jabref/logic/formatter/Formatters.java # src/main/java/org/jabref/migrations/PreferencesMigrations.java # src/main/java/org/jabref/model/entry/BibtexSingleField.java # src/main/java/org/jabref/model/entry/InternalBibtexFields.java # src/main/resources/l10n/JabRef_en.properties # src/test/java/org/jabref/logic/formatter/FormatterTest.java

Small fixes

* Add VSCode and Cancel icons. Remove lcd antialiasing for buttons. * Completely remove explicit font aliasing from icons

…o maintable-beta

…ble-beta

Commits on Jan 29, 2018

Revert sorting fix

tobiasdiez committed Jan 29, 2018

Configuration menu

View commit details

Copy full SHA for 8534235

Browse repository at this point

Copy the full SHA

8534235 View commit details

Browse the repository at this point in the history

Commits on Feb 5, 2018

Add test menu

tobiasdiez committed Feb 5, 2018

Configuration menu

View commit details

Copy full SHA for 2fc5a34

Browse repository at this point

Copy the full SHA

2fc5a34 View commit details

Browse the repository at this point in the history

Commits on Feb 7, 2018

Start reworking file menu

tobiasdiez committed Feb 7, 2018

Configuration menu

View commit details

Copy full SHA for ddc5325

Browse repository at this point

Copy the full SHA

ddc5325 View commit details

Browse the repository at this point in the history

Commits on Feb 12, 2018

Add help action to menu

tobiasdiez committed Feb 12, 2018

Configuration menu

View commit details

Copy full SHA for 3c8a07b

Browse repository at this point

Copy the full SHA

3c8a07b View commit details

Browse the repository at this point in the history

Commits on Feb 13, 2018

Convert global search to JavFX

tobiasdiez committed Feb 13, 2018

Configuration menu

View commit details

Copy full SHA for 8165e0e

Browse repository at this point

Copy the full SHA

8165e0e View commit details

Browse the repository at this point in the history

Commits on Mar 1, 2018

Track telemetry of each action (#3789 )

tobiasdiez authored Mar 1, 2018

Configuration menu

View commit details

Copy full SHA for 3710be8

Browse repository at this point

Copy the full SHA

3710be8 View commit details

Browse the repository at this point in the history

[WIP] Main table JavaFX migration #3621

[WIP] Main table JavaFX migration #3621

Commits on Jan 29, 2018

Commits on Jan 30, 2018

Commits on Jan 31, 2018

Commits on Feb 1, 2018

Commits on Feb 2, 2018

Commits on Feb 3, 2018

Commits on Feb 5, 2018

Commits on Feb 6, 2018

Commits on Feb 7, 2018

Commits on Feb 8, 2018

Commits on Feb 9, 2018

Commits on Feb 10, 2018

Commits on Feb 11, 2018

Commits on Feb 12, 2018

Commits on Feb 13, 2018

Commits on Feb 16, 2018

Commits on Feb 17, 2018

Commits on Feb 19, 2018

Commits on Feb 20, 2018

Commits on Feb 21, 2018

Commits on Feb 22, 2018

Commits on Feb 26, 2018

Commits on Feb 27, 2018

Commits on Mar 1, 2018

Commits on Mar 2, 2018

Commits on Mar 3, 2018

Commits on Mar 4, 2018

Commits on Mar 5, 2018

Commits on Mar 7, 2018

Commits on Mar 9, 2018

Commits on Mar 11, 2018

Commits on Mar 12, 2018

Commits on Mar 13, 2018

Commits on Mar 14, 2018

Commits on Mar 16, 2018

Commits on Mar 18, 2018

Commits on Mar 19, 2018

Commits on Mar 23, 2018

Commits on Mar 24, 2018

Commits on Mar 25, 2018

Commits on Mar 26, 2018

Commits on Mar 27, 2018

Commits on Mar 28, 2018

Commits on Mar 31, 2018

Commits on Apr 1, 2018

Commits on Apr 2, 2018

Commits on Apr 4, 2018

Commits on Apr 7, 2018

Commits on Apr 11, 2018

Commits on Apr 13, 2018

Commits on Apr 14, 2018

Commits on Apr 15, 2018

Commits on Apr 23, 2018

Commits on Apr 25, 2018

Commits on Apr 26, 2018

Commits on Apr 28, 2018

Commits on Apr 29, 2018

Commits on Apr 30, 2018

Commits on May 1, 2018

Commits on May 2, 2018

Commits on May 4, 2018

Commits on May 6, 2018

Commits on May 7, 2018

Commits on May 10, 2018

Commits on May 11, 2018

Commits on May 12, 2018

Commits on May 13, 2018

Commits on May 15, 2018

Commits on May 18, 2018

Commits on May 20, 2018

Commits on May 22, 2018

Commits on May 25, 2018

Commits on May 26, 2018

Commits on May 31, 2018

Commits on Jun 1, 2018